From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9867A0563; Tue, 10 Mar 2020 08:48:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B93C31C012; Tue, 10 Mar 2020 08:48:31 +0100 (CET) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 8AAC61BF96; Tue, 10 Mar 2020 08:48:29 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id B322D23F7; Tue, 10 Mar 2020 03:48:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 10 Mar 2020 03:48:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=HiF1PFlgs0DZ6Ew7INr56hoCp72PDsrKH/pqlqFLJuQ=; b=EW7HPIXC86/Y ZSxzM6S41y/lQWBRry4a0GXbLIlW1n7pyV6Khxhta6t2zfFsSzWS+A0NjVRxWkF3 3weCmfGxcLs3Qzo09Sh2ZSRwZb8gLXZseBJJoiRSD1XOdoWpXu0rfkqi325le24T s4hfcH7TGTiw9QtzlAZQCiWqwuVqXgw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=HiF1PFlgs0DZ6Ew7INr56hoCp72PDsrKH/pqlqFLJ uQ=; b=av2vnThM/Xh7poidpD2zx56x9uPtBHAQZLvQ+1z6CeQUHc9ofgKGeeKwO uHwhim8KB+kF/tf98YC/Cde9VPM5QWlKBAE0IPsLwxfmasUeh/ISZSzW0Df+xdBC eivWS/pmd5+/7cn3lPMu1WsmO1rvWJV9pPxv0dTpABJIrsYXnQM0NA6D/XiC+bvz TiCow35W/CUayOwYqZLd3/DKxE1nHHwBrQlWPr/RNAeGhey64jQrh+nMzObAKjjG VMLpcodpwceSHfqH2kZhwOn4RIVyZK5w9iBLtIUHnpT+USfvpyi4somn6XkqfcZq iwPzLNpAkBu+xoxQZQzKUWCp3ACYw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudduledguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ffohhmrghinhepughpughkrdhorhhgpdhtrhgrvhhishdqtghirdgtohhmnecukfhppeej jedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CEE873280059; Tue, 10 Mar 2020 03:48:25 -0400 (EDT) From: Thomas Monjalon To: Kevin Traynor , David Marchand , "Ye, Xiaolong" , "Wang, Haiyue" Cc: dev , "Zhang, Qi Z" , "Yang, Qiming" , "Xing, Beilei" , "Zhao1, Wei" , Aaron Conole , "ci@dpdk.org" , "Yigit, Ferruh" Date: Tue, 10 Mar 2020 08:48:23 +0100 Message-ID: <21697353.6Emhk5qWAg@xps> In-Reply-To: References: <20200309141437.11800-1-haiyue.wang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 0/4] add Intel DCF PMD support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/03/2020 03:00, Wang, Haiyue: > > -----Original Message----- > > From: Kevin Traynor > > Sent: Tuesday, March 10, 2020 03:34 > > To: Thomas Monjalon ; David Marchand ; Ye, Xiaolong > > > > Cc: Wang, Haiyue ; dev ; Zhang, Qi Z ; Yang, > > Qiming ; Xing, Beilei ; Zhao1, Wei ; > > Aaron Conole ; ci@dpdk.org; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [PATCH v1 0/4] add Intel DCF PMD support > > > > On 09/03/2020 17:57, Thomas Monjalon wrote: > > > 09/03/2020 17:20, Ye Xiaolong: > > >> Hi, David > > >> > > >> On 03/09, David Marchand wrote: > > >>> On Mon, Mar 9, 2020 at 3:22 PM Haiyue Wang wrote: > > >>>> > > >>>> A DCF (Device Config Function) based approach is proposed where a device > > >>>> bound to the device's VF0 can act as a sole controlling entity to exercise > > >>>> advance functionality (such as switch, ACL) for rest of the VFs. > > >>>> > > >>>> The DCF works as a standalone PMD to support this function, which shares the > > >>>> ice PMD flow control core function and the iavf virtchnl mailbox core module. > > >>>> > > >>>> This patchset is based on: > > >>>> [1] https://patchwork.dpdk.org/cover/66417/ update ice base code > > >>> > > >>> The problem is that the CI(s) won't handle this. > > >>> Example for the robot: https://travis-ci.com/ovsrobot/dpdk/builds/152461907 > > >>> > > >>> Maybe we could add something as an annotation to the cover letter or > > >>> the first patch of a series so that the CI(s) can detect and try to be > > >>> intelligent? > > >> > > >> Agree, It'd be helpful if the cover letter of the first patch contains some > > >> base tree info including the base commit and dependency patchset info (if any), > > >> so the CI can determine the correct base on top of which the developer's > > >> patchset applies to avoid any apply issue and potential false positive. > > >> > > >> And I know there is one option '--base'' of `git format-patch` which is > > >> dedicated for this kind of usage, it can help create the base tree info block > > >> which can be easily consumed by the CI. Here is the simple intro of it. > > >> > > >> Imagine that on top of the public commit P (already in upstream), the developer > > >> applied well-known (on-flight, in the mailing list but not merged yet) patches > > >> X, Y and Z from somebody else or himself, and then built his three-patch series > > >> A, B, C, the commit history would be like: > > >> > > >> ................................................ > > >> ---P---X---Y---Z---A---B---C > > >> ................................................ > > >> > > >> With `git format-patch --base=P -3 C`, > > >> > > >> where P could be the exact commit sha, or variants e.g. HEAD~6, we can also use > > >> --base=auto for convenience, the base tree information block will be shown at > > >> the end of the first message the command outputs (either the first patch, or > > >> the cover letter), like this: > > >> > > >> ------------ > > >> base-commit: P > > >> prerequisite-patch-id: X > > >> prerequisite-patch-id: Y > > >> prerequisite-patch-id: Z > > >> ------------ > > >> > > >> Here P is the commit sha, and X,Y,Z are the patch ids of the dependency patches. > > >> > > >> > > >> With this info in place, I think CI should be able to setup the exact base for > > >> the coming patchset, the missing part I can see is the mapping of > > >> (in-flight patch <-> patch id), since we have all the in-flight patches in > > >> patchwork, creating and maintaining such mapping in DB is doable, what do you > > >> think? > > > > > > I think it would simpler to list dependencies as patchwork ids. > > > Example: > > > Depends-on: series-42, patch-12345 > > > > > > > Just list the 'series' ? Since it can download the whole patchset with > the single link format like: > > Depends-on: series-8843 --> https://patchwork.dpdk.org/series/8843/mbox/ Yes, I was proposing both format: series-X and patch-Y (on top of series-X). But we probably never need to be specific about a single patch. I think you are right, we can keep only "series-X" syntax, and allow describing a list of series, ordered and separated with comma.