From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id AEE4F1CA74
 for <dev@dpdk.org>; Thu,  5 Apr 2018 12:06:11 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 5305E21945;
 Thu,  5 Apr 2018 06:06:11 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Thu, 05 Apr 2018 06:06:11 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=KWiuniWZjYM5Vbu7MxjGuvkLTo
 tAK2/+no3lF9signo=; b=jubhg/qNHXiGOlG/H//uIAUeZZgwbln00gLQI5Rkml
 I8t7DtM80luDKC+JPUf7p0FEThs/RIwxbz83qnya0L5TQaWR7T7qTlgtZo+L8cNx
 Da/2vNwWdfnS4CPwfl9kCRTSRbVRiVES87c4FMeCptIlXyd+V21nXkGy+KA407IP
 g=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=KWiuni
 WZjYM5Vbu7MxjGuvkLTotAK2/+no3lF9signo=; b=l7/dJoZbo4g3Wn0yVYx7E1
 OtEVSczzyyRjxRQERvn3dr1xBDJHox8sMt87QPI+FoXrneE92E+N6xNyvrbGK7QA
 PUg+Z26fyOPgRtLADKrSuMcRhyOM/gx1/4NCd24Xm33gP3RlcEpbFzYoXeDGE5ue
 MnE9JraQmuVjt4IA9yV85NqeZLMeDJHOPTH/qygh09SgIfCTWv0uSWkZESFD3qqL
 4Fxpe1+LXWWK3IpkU3Jw2fGvw0oC0R86BsfXSE0pKQSgYsg9oRHT9Cfc2JMD+iRN
 W5ixkoRZhGbczdGcW2uXuZdMhgXsrTxGx/0AtPzIFOHT+9PQVk0IhR82/y1Dy5DQ
 ==
X-ME-Sender: <xms:E_XFWvo1z546JtN_bnhdB-xXSYXOozOkvNhk5abYYHb3fYGm9ImKzQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id BC1B3E4F68;
 Thu,  5 Apr 2018 06:06:10 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Date: Thu, 05 Apr 2018 12:06:10 +0200
Message-ID: <2170144.NMypU1fd1R@xps>
In-Reply-To: <20180404150312.12304-2-adrien.mazarguil@6wind.com>
References: <20180404150312.12304-1-adrien.mazarguil@6wind.com>
 <20180404150312.12304-2-adrien.mazarguil@6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v1 01/16] ethdev: update ABI for flow API
	functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Apr 2018 10:06:11 -0000

04/04/2018 17:56, Adrien Mazarguil:
> Subsequent patches will modify existing types and slightly alter the
> behavior of the flow API. This warrants a major ABI breakage.
> 
> While it is already taken care of for 18.05 (LIBABIVER was updated to
> version 9 by a prior commit), this patch explicitly adds the affected flow
> API functions as a safety measure.

I don't understand this patch.

If the API is broken, you must move the function from old block to
the new one. And it must be done in the patch modifying the function.


> --- a/lib/librte_ether/rte_ethdev_version.map
> +++ b/lib/librte_ether/rte_ethdev_version.map
> +DPDK_18.05 {
> +	global:
> +
> +	rte_flow_validate;
> +	rte_flow_create;
> +	rte_flow_query;
> +	rte_flow_copy;
> +
> +} DPDK_18.02;