From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 5D833A0C43;
	Wed, 20 Oct 2021 21:20:05 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2986140150;
	Wed, 20 Oct 2021 21:20:05 +0200 (CEST)
Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com
 [66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id 50F9240142
 for <dev@dpdk.org>; Wed, 20 Oct 2021 21:20:04 +0200 (CEST)
Received: from compute6.internal (compute6.nyi.internal [10.202.2.46])
 by mailnew.nyi.internal (Postfix) with ESMTP id 0240D581002;
 Wed, 20 Oct 2021 15:20:04 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute6.internal (MEProxy); Wed, 20 Oct 2021 15:20:04 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm2; bh=
 4feS8KWhhVhKopvcKKV1Dw8krgZLnsr4GQfhkEOS4vU=; b=Lgxld8hmPalGFljp
 GD1W5IbU5RwYiCoH1VDSW+/BWw1F/8joOUTauHzk1Vqk3ER0WHqdJ3+Ew5Ae+Fcr
 CA53LK1l57C4AdvM4Ufn1DttCG+FAleNkc7N2kf4nwRjRxonj8nrAtuGpdLSCqO7
 ROmBfjl4UyfeRLkLWp/iBSwfbMMEOyvm8fyoms+L89ZBOYA+bRyZm8JBYpPth4y8
 C46R+j0itQA8A0ty80BxXdW0s8VX2DhEGfjT1OP5SZhzueS6pSd9Abqg/bQiGyMV
 dCY3v8JVrbHIhUOaZO0kWECQGfuuys5F+0q0VnFoi/A2Ft/0F8DOUE61o7vY8Yvx
 aIc2uQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=4feS8KWhhVhKopvcKKV1Dw8krgZLnsr4GQfhkEOS4
 vU=; b=VKl//yUJsDeoLSBCM8N3NVOrbvNKrx4tfJI8WWSDdaADmeDAtKjsxPtdl
 pvI1tnx/3gUzqhd8sypyqV8pAlfy4/asO7QwpNG+rLYlptyZkaD6l+jBRF9zrglD
 s1VkE6DGJszjSEF3YU6YwAgiz+Mxo/ykE/+2vc0gAMijDD9x5Od50J0qzDo16Bg1
 2c8wUS0kaobwkP8E5t0KBhIbYSWLOsMdGZOL+Z1rYsFwLA2kFsbUv9okR1AEk+iv
 iJUezdMUHOvOI6zOO3KsR36InRtnfEM1G02NMr8PlGII8KnGKlE26RPoIBO0+onk
 TT/Yo69QOTOyOTpe33z01lDCR7n+w==
X-ME-Sender: <xms:42twYT0pCS8NQQbU7muNxxeC8ijGL0ZkSLxWwNtq9GTOUtTOIEKcVA>
 <xme:42twYSF5JXRGDD_WoDxg0UG0MeKxxxJd5g4bjxwFmxFEQIRdlaPHqKF-aaXDiBz0t
 xRlL21PxKv4QZDYbA>
X-ME-Received: <xmr:42twYT6RlF4Hpmz4oufMqAViF5hpaiqTwa6t-zzimfvBOL9tni5v33CNHm6sTd5Y-sBmBca0IsLoYrTihFhqhA-OJw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddvgedgudefudcutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
 rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
 ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej
 ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh
 hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:42twYY33yq3dzLWB3trH58nKzRlYm8xV9ZaxoSvJaLNL-e738CwJKA>
 <xmx:42twYWHZExJmsi3BnDYgQ5OjV_hp2kbbIZ3RYSAJoZjZpwZXeBAFsA>
 <xmx:42twYZ9QE4yX6YkmpSKjVdNiQnGPO6q4YPVn89SdcHFhrxotxUCTMQ>
 <xmx:42twYZAVcd_gmomdqVNA-cc20_oWiJZnu47zZG8k8qlI1wLr9C2RkQ>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
 20 Oct 2021 15:20:02 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Xueming Li <xuemingl@nvidia.com>
Cc: dev@dpdk.org, Zhang Yuying <yuying.zhang@intel.com>,
 Jerin Jacob <jerinjacobk@gmail.com>, Ferruh Yigit <ferruh.yigit@intel.com>,
 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
 Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
 Lior Margalit <lmargalit@nvidia.com>,
 Ananyev Konstantin <konstantin.ananyev@intel.com>,
 Ajit Khaparde <ajit.khaparde@broadcom.com>, Xiaoyun Li <xiaoyun.li@intel.com>
Date: Wed, 20 Oct 2021 21:20:00 +0200
Message-ID: <2170345.CEVlqgciO5@thomas>
In-Reply-To: <20211020075319.2397551-8-xuemingl@nvidia.com>
References: <20210727034204.20649-1-xuemingl@nvidia.com>
 <20211020075319.2397551-1-xuemingl@nvidia.com>
 <20211020075319.2397551-8-xuemingl@nvidia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v11 7/7] app/testpmd: add forwarding engine
 for shared Rx queue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

20/10/2021 09:53, Xueming Li:
> To support shared Rx queue, this patch introduces dedicate forwarding
> engine. The engine groups received packets by mbuf->port into sub-group,
> updates stream statistics and simply frees packets.

Given this engine is mentioned in previous commits,
shouldn't it be placed earlier in the series?

> +#include <stdarg.h>
> +#include <string.h>
> +#include <stdio.h>
> +#include <errno.h>
> +#include <stdint.h>
> +#include <unistd.h>
> +#include <inttypes.h>
> +
> +#include <sys/queue.h>
> +#include <sys/stat.h>
> +
> +#include <rte_common.h>
> +#include <rte_byteorder.h>
> +#include <rte_log.h>
> +#include <rte_debug.h>
> +#include <rte_cycles.h>
> +#include <rte_memory.h>
> +#include <rte_memcpy.h>
> +#include <rte_launch.h>
> +#include <rte_eal.h>
> +#include <rte_per_lcore.h>
> +#include <rte_lcore.h>
> +#include <rte_atomic.h>
> +#include <rte_branch_prediction.h>
> +#include <rte_mempool.h>
> +#include <rte_mbuf.h>
> +#include <rte_pci.h>
> +#include <rte_ether.h>
> +#include <rte_ethdev.h>
> +#include <rte_string_fns.h>
> +#include <rte_ip.h>
> +#include <rte_udp.h>
> +#include <rte_net.h>
> +#include <rte_flow.h>

Please do not include useless files.