From: Thomas Monjalon <thomas@monjalon.net>
To: Michael Baum <michaelba@nvidia.com>
Cc: dev@dpdk.org, stable@dpdk.org, Matan Azrad <matan@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 2/4] compress/mlx5: fix constant size in QP creation
Date: Wed, 23 Jun 2021 08:47:48 +0200 [thread overview]
Message-ID: <2171041.exsR1beKra@thomas> (raw)
In-Reply-To: <20210601071122.1612432-2-michaelba@nvidia.com>
01/06/2021 09:11, Michael Baum:
> The mlx5_compress_qp_setup function makes shifting to the numeric
> constant 1, then sends it as a parameter to rte_calloc function.
>
> The rte_calloc function expects to get size_t (64 bits, unsigned) and
No on 32-bit systems, size_t is 32 bits.
> instead gets a 32-bit variable, because the numeric constant size is a
> 32-bit.
Most of the patches of this series say "constant" where it is a variable.
> In case the shift is greater than 32 the variable will lose its value
> even though the function can get 64-bit argument.
>
> Change the size of the numeric constant 1 to 64-bit.
[...]
> - opaq_buf = rte_calloc(__func__, 1u << log_ops_n,
> + opaq_buf = rte_calloc(__func__, RTE_BIT64(log_ops_n),
next prev parent reply other threads:[~2021-06-23 6:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 7:11 [dpdk-dev] [PATCH 1/4] regex/mlx5: fix size of setup constants Michael Baum
2021-06-01 7:11 ` [dpdk-dev] [PATCH 2/4] compress/mlx5: fix constant size in QP creation Michael Baum
2021-06-07 7:28 ` Matan Azrad
2021-06-23 6:47 ` Thomas Monjalon [this message]
2021-06-28 14:21 ` [dpdk-dev] [dpdk-stable] " Michael Baum
2021-06-01 7:11 ` [dpdk-dev] [PATCH 3/4] vdpa/mlx5: fix constant type " Michael Baum
2021-06-07 7:29 ` Matan Azrad
2021-06-01 7:11 ` [dpdk-dev] [PATCH 4/4] net/mlx5: fix constant type in MP allocation Michael Baum
2021-06-07 7:29 ` Matan Azrad
2021-06-07 7:28 ` [dpdk-dev] [PATCH 1/4] regex/mlx5: fix size of setup constants Matan Azrad
2021-07-01 6:39 ` [dpdk-dev] [PATCH v2 " Michael Baum
2021-07-01 6:39 ` [dpdk-dev] [PATCH v2 2/4] compress/mlx5: fix constant size in QP creation Michael Baum
2021-07-01 6:39 ` [dpdk-dev] [PATCH v2 3/4] vdpa/mlx5: fix constant type " Michael Baum
2021-07-01 6:39 ` [dpdk-dev] [PATCH v2 4/4] net/mlx5: fix constant type in MP allocation Michael Baum
2021-07-22 12:50 ` [dpdk-dev] [PATCH v2 1/4] regex/mlx5: fix size of setup constants Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2171041.exsR1beKra@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=michaelba@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).