From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78BA3A0C41; Wed, 23 Jun 2021 08:47:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F027E4003F; Wed, 23 Jun 2021 08:47:56 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id EE56B4003E; Wed, 23 Jun 2021 08:47:54 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 7818C5C0101; Wed, 23 Jun 2021 02:47:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 23 Jun 2021 02:47:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= eg72qzyXuD6PQPjFayNMivCBZp1DPbFBev32Op2w57U=; b=vyfbb9jvZsybmFwO /uDlCaL90ov8wXB885m6/Pg/sgHMs9oBKtTmEKqMsSbFREAa5zucbug5+Lzjp8gQ vtP96vF7iYkuUqfFh/tPJ+j76G6rcJFVJ7o2UjLyRVciSmC3c6HjI+lFyt0wiY0c zkhtBTVirPZ774RcQtTjC/S81qbj+MI1IUlYueNC2myd/b399x3yZRUfwKdDZJO/ ktNjiOIEIY+iT3diHzPAlYckleSu3hgniAgDZTENPEduNDd65jSiYb0aVruOqbls LSnyynSoypZA1Ty1QsMDPNHlGu3rzGfPuWL01+2oCy9tGUYf2u/3xPC1Icy1Ac1d EhyGGA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=eg72qzyXuD6PQPjFayNMivCBZp1DPbFBev32Op2w5 7U=; b=JuxGdYnm3aPt/7g6OgNR8W/uWMyDPC+HViRoyWxLbSJ1+dm2bbracXfkJ zmbI8rh4+B5hcyDoS81MZRwZAqTg7BP7ZqAOcEJqlYouqXQuh8HGUAlG1ZzXvVPe NMVn9UX4LYueELgjJYXR27EbijgIIyF551Rvwwj36ZLPQEjjJnPvZukDgtUEZ/3N fjr3SIdbMefdkezxGWI3kVCvVKLISoBiRzWu2rPyZyIPiEKqHE4lKiXTKTJbXCpA 6QfgyDBTIcc8q0JF1bpF9eGGdKBZQ57KHDUmCMjdFOR3yQoc9pxk+G6N9ZE+GIj3 Ua8T7rOubjOv7SIIvYfuSk05GXwTA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeegvddguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Jun 2021 02:47:51 -0400 (EDT) From: Thomas Monjalon To: Michael Baum Cc: dev@dpdk.org, stable@dpdk.org, Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko Date: Wed, 23 Jun 2021 08:47:48 +0200 Message-ID: <2171041.exsR1beKra@thomas> In-Reply-To: <20210601071122.1612432-2-michaelba@nvidia.com> References: <20210601071122.1612432-1-michaelba@nvidia.com> <20210601071122.1612432-2-michaelba@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 2/4] compress/mlx5: fix constant size in QP creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 01/06/2021 09:11, Michael Baum: > The mlx5_compress_qp_setup function makes shifting to the numeric > constant 1, then sends it as a parameter to rte_calloc function. > > The rte_calloc function expects to get size_t (64 bits, unsigned) and No on 32-bit systems, size_t is 32 bits. > instead gets a 32-bit variable, because the numeric constant size is a > 32-bit. Most of the patches of this series say "constant" where it is a variable. > In case the shift is greater than 32 the variable will lose its value > even though the function can get 64-bit argument. > > Change the size of the numeric constant 1 to 64-bit. [...] > - opaq_buf = rte_calloc(__func__, 1u << log_ops_n, > + opaq_buf = rte_calloc(__func__, RTE_BIT64(log_ops_n),