From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CACB8A0471 for ; Tue, 16 Jul 2019 13:26:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A81B72C18; Tue, 16 Jul 2019 13:26:51 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id 623572BF4 for ; Tue, 16 Jul 2019 13:26:50 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 5BD1A273; Tue, 16 Jul 2019 07:26:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 16 Jul 2019 07:26:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=NUUnv8wB4jYNTo9iEVJ6LqQox8A3P3VJg3DbeqYV4WI=; b=Wht2iXnwYu0s pF3RixdkjI89lwoXg29s0AlAyRWQlgNqICs/gJg7/tpo3HkzroNK4SeHo0O4rXYp tSjfixZnnrdhqY3ovno4He2BRYSVluY5MXVD1aKlzQrHq0fgkh/HWfWP0uIEtzPW Ym8YC5naZ1qzDOr1J5mnHRB8C018Mts= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=NUUnv8wB4jYNTo9iEVJ6LqQox8A3P3VJg3DbeqYV4 WI=; b=R2LR22jHzco7rHgzzwXjL/1DEmm6hjqxJ46f2YII7SFlRtCQ3bsNKfm6n i/9ztserVdZ7n5KHfERwIpYnpYXOUuQN2pGBqg+BOe/tyjlBHvI0Z4RIblOgh+F1 t3d29zsmRpgnmDzh6V5yBpO61cXkdxH/+cc7Vbt4n6H6c9hQWAb5S/N6n2VrYAPe YinfM2dASaUZIkpSBRbyxUJjrzegTyVtLOnNeB8KLKsBtBUZQx2K6ygetYyNyc++ 2ucziqef+Ue3W5StnRWTT5NGU/5eWuqk9cvFL71VWQzSlph/JO92p4ravAM4Evmy HYkr1RG5/Ituh+7P8hIhg5pnPS9hQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddriedtgdegvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E9A66380087; Tue, 16 Jul 2019 07:26:47 -0400 (EDT) From: Thomas Monjalon To: Konstantin Ananyev Cc: dev@dpdk.org, olivier.matz@6wind.com Date: Tue, 16 Jul 2019 13:26:46 +0200 Message-ID: <2172925.cb74tNeGR5@xps> In-Reply-To: <20190710141659.23964-1-konstantin.ananyev@intel.com> References: <20190710141659.23964-1-konstantin.ananyev@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples/ip_fragmentation: fix fail to send un-fragmented packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/07/2019 16:16, Konstantin Ananyev: > With latest changes l3fwd_simple_forward() blindly set > (PKT_TX_IPV4 | PKT_TX_IP_CKSUM) ol_flags for all IPv4 packets. > Though for un-fragmented packets we also do have to set l3_len > to make HW IP cksum offload to work properly. > That causes HWi/PMD to drop or generate invalid packets. > Though for un-fragmented packets we don't need to regenerate > IPv4 cksum, as L3 header is not modified. > Fix by setting ol_flags only when required. > Another small fix - don't set IPv4/IPV6 ether type for unknown > packet types. > > Fixes: 16863bbb4a41 ("examples/ip_fragmentation: enable IP checksum offload") Shouldn't it be 2 separate fixes?