From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id D6E545A59 for ; Tue, 23 Jun 2015 15:56:28 +0200 (CEST) Received: by wiwl6 with SMTP id l6so67302335wiw.0 for ; Tue, 23 Jun 2015 06:56:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=HQp91eht1kdPCnO3fm6LOXd+eQAPW/uGgXOB+xC84cU=; b=IDBPWzjo3zGbY6jrvTL3lEeTr7Ntr4/5YRdbynXIyW8dZQJVrTW6ouwJlYyAHj8hx6 d9H2h2QE4PIbaMZIUVmesfHAWCo2A/grnbV1rSsGG1FR5ZwJYkecxWeyJYRPaXhY2Bj5 m3xWPgUlvO4HZ9c3cZLmdCe6RMYvGeJbrOZdcxR+ERWeRxW3EqOqgqOpFoyZcG1Q1+at RANc2pMLQDivr3mb+s3RFhUgEgIMzUoHTzpskFhJRIVRmjw6llKvxYoPS0E8YZpbyumx iaSPZGO26hVvqY4espxS13GdUgOmCRi9DMfclHw2rW6RW9xEAZJpnNCyK0C5M7b/k7YR 81mQ== X-Gm-Message-State: ALoCoQn4zMQRvkHmSqWP8/kjp5QOOaZ4IpoPHZidx0f7jQJx5kpCJ+jP4V84hQm+m/r42K58Jkos X-Received: by 10.180.14.193 with SMTP id r1mr3683590wic.47.1435067788744; Tue, 23 Jun 2015 06:56:28 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id js3sm35765886wjc.5.2015.06.23.06.56.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Jun 2015 06:56:28 -0700 (PDT) From: Thomas Monjalon To: Maciej Gajdzica Date: Tue, 23 Jun 2015 15:55:25 +0200 Message-ID: <2173119.kJ61eenqfH@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1434706885-4519-2-git-send-email-maciejx.t.gajdzica@intel.com> References: <1434706885-4519-1-git-send-email-maciejx.t.gajdzica@intel.com> <1434706885-4519-2-git-send-email-maciejx.t.gajdzica@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 01/13] port: added structures for port stats and config option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jun 2015 13:56:29 -0000 2015-06-19 11:41, Maciej Gajdzica: > /** Input port interface defining the input port operation */ > struct rte_port_in_ops { > rte_port_in_op_create f_create; /**< Create */ > rte_port_in_op_free f_free; /**< Free */ > rte_port_in_op_rx f_rx; /**< Packet RX (packet burst) */ > + rte_port_in_op_stats_read f_stats; /**< Stats */ > }; Isn't it breaking an ABI? > struct rte_port_out_ops { > - rte_port_out_op_create f_create; /**< Create */ > - rte_port_out_op_free f_free; /**< Free */ > - rte_port_out_op_tx f_tx; /**< Packet TX (single packet) */ > - rte_port_out_op_tx_bulk f_tx_bulk; /**< Packet TX (packet burst) */ > - rte_port_out_op_flush f_flush; /**< Flush */ > + rte_port_out_op_create f_create; /**< Create */ > + rte_port_out_op_free f_free; /**< Free */ > + rte_port_out_op_tx f_tx; /**< Packet TX (single packet) */ > + rte_port_out_op_tx_bulk f_tx_bulk; /**< Packet TX (packet burst) */ > + rte_port_out_op_flush f_flush; /**< Flush */ What is the goal of this change? Breaking the alignment? > + rte_port_out_op_stats_read f_stats; /**< Stats */