From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0888FA0032; Tue, 16 Nov 2021 16:05:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC4A04115A; Tue, 16 Nov 2021 16:05:40 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 09A0741142 for ; Tue, 16 Nov 2021 16:05:40 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 5554F5C0032; Tue, 16 Nov 2021 10:05:39 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 16 Nov 2021 10:05:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 0aEwu6PYQsGuYkBXleVFFbsCEHyU6YSJ9z4ITE3MOQE=; b=jUwvglep3Aan/wsB QdC7uC8QyY8BTslTK3lMGj9WW0V65MZuu8vqcxE2mj8xMQiJIJWVtZa3LaZHHJGY ipuZH8L5hYHoKgivxPqMMgq7uvdYhXRRTSIJ0/8BY9o3m7wTPUXeU5vCCrvEwPxr noJ78FYniEyOk0H13QseEG8fKY/5a4IAftS/M2z5YyIYOlSbecGdZE/gH0oQJcM7 MZHV2dqPRLP6mz4UzCiY7r+bMItCZEUnlLDtdAfKLOqaGdsozNG5CUhMZgMbxxcm KyKoudqab9yDCm6xARtsZ9q8FNURbyl/BNB86PUuYMSBzrbb5OSb2YZhlOo7OLsM eUygyg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=0aEwu6PYQsGuYkBXleVFFbsCEHyU6YSJ9z4ITE3MO QE=; b=MMOqqMqD5Zm0OUWWi3EAe3P6km8Ea6fpfcnOXgR75RhTMKJGcxDr7m2TC eBjXL0cWk+RBqw28JbtI05kZw6wyOAz/0eOwx+GiuTKp8tAnEbx+BenrY+alRGaU NOTcx0HfEZgm96yb1N3VxXFTHITFXW679OW0d3nTT5iFBbdEpbXLFQ1eiTHsHW3K IVsER3h0Ys2VQpRiw+mtwG9UgqvIZkaHBY037N55viSdvgESj6+ccumwCpXEHUBL /r1pHEbnlHv1eArK1PUSlCAI7URR7nGG5I29Tq71sNU1UC5SWEhjBrCo/iYvsNUu 2wBtVvvHpA2t6/nq6zZih4vqeVb/Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrfedvgdejtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 16 Nov 2021 10:05:37 -0500 (EST) From: Thomas Monjalon To: Gregory Etelson Cc: dev@dpdk.org, viacheslavo@nvidia.com, matan@nvidia.com, rasland@nvidia.com Subject: Re: [PATCH] doc: add mlx5 PMD flex item documentation Date: Tue, 16 Nov 2021 16:05:36 +0100 Message-ID: <2173190.Li0gZhyFnm@thomas> In-Reply-To: <20211116145139.837-1-getelson@nvidia.com> References: <20211116145139.837-1-getelson@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/11/2021 15:51, Gregory Etelson: > Describe firmware configuration requirements. > List mlx5 hardware and PMD limitations. That's a pity we missed documentation when adding the feature. Please a line "Fixes". [...] > +- Flex item API: > + > + - Firmware configuration: ``FLEX_PARSER_PROFILE_ENABLE=4 PROG_PARSE_GRAPH=1``. This is not a limitation and it is redundant with the last part of this patch. > + - Hardware support: BlueField-2. I think it should be a space: BlueField 2 > + - Flex item is supported on PF only. > + - Hardware limits ``header_length_mask_width`` up to 6 bits. > + - Firmware supports 8 global sample fields. Each flex item allocates non-shared sample fields from that pool. Please break lines after a dot. > + - Supported flex item can have 1 IN arc - ``eth`` or ``udp`` and up to 2 OUT arcs - ``ipv4`` or ``ipv6``. Is "arc" defined somewhere? > + - Flex item fields (next_header, next_protocol, samples) do not participate in RSS hash functions. Fields should be enclosed with quotes. > + - In RTE flex item configuration, ``next_header.field_base`` value must be byte aligned (multiple of 8). Please don't say "RTE". [...] > +- enable dynamic flex parser for RTE flex item:: Again, please stop using "RTE". I really wonder why I see this in a lot of patches. In user doc, it doesn't make sense at all. If you really want to distinguish API and driver implementation, use "API". > + > + FLEX_PARSER_PROFILE_ENABLE=4 > + PROG_PARSE_GRAPH=1