From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 152F99A9E for ; Fri, 13 May 2016 17:35:44 +0200 (CEST) Received: by mail-wm0-f45.google.com with SMTP id e201so27396795wme.0 for ; Fri, 13 May 2016 08:35:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZNwySg165M6TPlVuL6AtRi9BuX0yDP6CNF+8WZV8hRU=; b=S9gFistP/H+hoRgGVwANy8cnAhw68KNweLtqCTVV1HEvhUeDxbxAtApLzM09G3nT0J ZRm51ZGFe9uEmB141EySrnj0wHP7nBWsk10hqNNKDEPECm0F7tM8KamYADBK5c6z0wqy 8xazCLDxADlzdzkVhqA8wZP55Zo68FMozENqEUmlRbwKT7+2aaXKz4qYYxLInPwV4LN1 dxYLpxh2+HuRlNMYsRkdEBtk6NzbDaX0UKKGfSwTeK4e6Rw3Wxp6Fz0L3nZNvVvUe7c1 Oz7E+6MWXvPcMuCUMEYsuqkGIXGxJQq2nzWhBvulzXUr69lRZb4Y46sTOy3MO9NpbY83 Xe0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=ZNwySg165M6TPlVuL6AtRi9BuX0yDP6CNF+8WZV8hRU=; b=fhYdUGVS+Tofhlp4jiTTjVeNZkLJZ8gILDxsHHgLzNuVj8yevFQbxWR1K3ZLcwsEoJ Yb/rKfWH6vTu2R2kqga58OD0Vn7iXBJhLfDevxPW2HLfQxn65dYJ8u9xJQNcqW2idMV8 oMvOem6SdyLF+xBX4zC4kEj+KHWOn9mfQeUcFfh1AyQlrqJdnphPz3Yqwv8Fzs5Etd8L uMYYWDIRss1LDTn2Q6C+AhZVgfoTp3SIijW3V7UVY4BrH8JWYdbPC8bl1hCPCHKNm7pg XuANr0GkvLJPvqqggzNjBJyyl3WPlW0Gp3eNM3ynHK5XpE82KbSYRa2DKF63G1FqGHTn l1BQ== X-Gm-Message-State: AOPr4FUBc5C+kX5UPRJQcp72jHWO+wpfT627r7H2gx7jsBUcqLiH16yus4y8sN227i/Exyxa X-Received: by 10.28.23.138 with SMTP id 132mr4558860wmx.50.1463153743888; Fri, 13 May 2016 08:35:43 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id b12sm3845089wmb.0.2016.05.13.08.35.42 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 13 May 2016 08:35:43 -0700 (PDT) From: Thomas Monjalon To: Jan Viktorin Cc: dev@dpdk.org, David Marchand , Bruce Richardson Date: Fri, 13 May 2016 17:35:42 +0200 Message-ID: <2173920.FKvWuSveuV@xps13> User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160513171942.231577b4@pcviktorin.fit.vutbr.cz> References: <1462904011-29838-1-git-send-email-viktorin@rehivetech.com> <1590761.7jRYD2v3H6@xps13> <20160513171942.231577b4@pcviktorin.fit.vutbr.cz> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 08/11] app/test: convert current pci_test into a single test case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2016 15:35:44 -0000 2016-05-13 17:19, Jan Viktorin: > On Thu, 12 May 2016 17:34:13 +0200 > Thomas Monjalon wrote: > > > 2016-05-10 20:13, Jan Viktorin: > > > The current test_pci is just a single test case that tests the blacklisting > > > of devices. Rename it to test_pci_blacklist and call it from the test_pci. > > > > The functions are also moved. It is confusing. > > Maybe this patch can be squashed with the previous one. > > > > Well, I wanted to separate the functional changes from cosmetic ones. > The goal here is to extract the setup and cleanup phases from the orignal > test. Would be better to just change the description? > > --- > > app/test: extract setup and cleanup phase from pci_test > > The original test_pci contains the setup and cleanup phase in its body. > By extracting this code out, we can take advantage of this code for other > (future) tests as well. > > The test_pci is renamed to test_pci_blacklist - it's only a single test > case (others will follow) now. > > --- > > Probably, it can be splitted (instead of squashed with a previous one) to > "extract setup and cleanup" and "rename to test_pci_blacklist". Not a big deal, I will check in v3. Thanks