From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9ADC0A0487 for ; Tue, 30 Jul 2019 00:19:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 60ED91BFA5; Tue, 30 Jul 2019 00:19:04 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id A7E411BF86 for ; Tue, 30 Jul 2019 00:19:02 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 331A822185; Mon, 29 Jul 2019 18:19:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 29 Jul 2019 18:19:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=yqZvXPOGNPB/HjFa7YddY76IUZbC8pVR1DY3rn92ISc=; b=Sh36jJa2z6wU ebAR4X+SluXbbvNqxDOAaek47C0li+gaUadqdrsEKtijSqJ5najWFNZ2QnYNBLUM tYnrM0YH1CSVJG9XuJgyBPKozZPtlEqvPGBV491TeLvVmhsl+j1JV0RaPBfvrIOd Rkyy2yhTHyuO47ZBZcYX0+jMbVkLXnI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=yqZvXPOGNPB/HjFa7YddY76IUZbC8pVR1DY3rn92I Sc=; b=yL1uREZpPIgI4EDRD8mKPciJunA2EtU3JaGiJ65F+k6lx42F2yO2VonCd DTWEnDJtSfBA3oeMAg4KSABVMunjiaDAUMkedWj6xlmyRzEO+HjzGrOQv7CDlium LnN2OYzScVx7tUPr5UaCnTGKfx+l3lg7qV6bdW2JOr8jqbQYfh0CP38mJdcih22L z1wtzw9VFUgfSqkcmk5T+oi3atSBRUUPQhOf+sT/dbkSk0v0BTPUjbGXaq0gSxRk stuCbgGGLs9O3mJ3+BApXPVurg/mq6dYiltRC9MG7BI5QK7F06VQ8P2OIvl0l2vZ 9qzk1vT304pbD6jzGJqejFgQ1ck4g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrledvgddtkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3E39A8005C; Mon, 29 Jul 2019 18:19:00 -0400 (EDT) From: Thomas Monjalon To: Harman Kalra Cc: dev@dpdk.org, John McNamara , Pablo de Lara , Bruce Richardson , Harry van Haaren , Xiaoyun Li , "barbette@kth.se" , Yongseok Koh , viacheslavo@mellanox.com Date: Tue, 30 Jul 2019 00:18:59 +0200 Message-ID: <2174860.Ph4OkxdjrP@xps> In-Reply-To: <1564069902-3500-1-git-send-email-hkalra@marvell.com> References: <1564069902-3500-1-git-send-email-hkalra@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples/rxtx_callbacks: fix HW timestamp enable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/07/2019 17:51, Harman Kalra: > Offloafing Rx timestamp is a device capability than queue capability. Why is it a device capability and not a queue capability? > Hence the logic to enable HW timestamp via DEV_RX_OFFLOAD_TIMESTAMP > flag should be before device configuration. > > Fixes: cd1dadeb9b2a ("examples/rxtx_callbacks: support HW timestamp") > Cc: barbette@kth.se > > Signed-off-by: Harman Kalra