* [dpdk-dev] [PATCH v1] app/regex: configure qp according to device capabilities
@ 2020-10-20 9:10 guyk
2020-10-20 9:14 ` Ori Kam
0 siblings, 1 reply; 6+ messages in thread
From: guyk @ 2020-10-20 9:10 UTC (permalink / raw)
To: orika; +Cc: thomas, guyk, smadarf, dovrat, dev
From: Guy Kaneti <guyk@marvell.com>
configure qp with OOS according to device capabilities
returned from rte_regexdev_info_get.
Signed-off-by: Guy Kaneti <guyk@marvell.com>
---
app/test-regex/main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/app/test-regex/main.c b/app/test-regex/main.c
index e6080b44b..3deaf3c80 100644
--- a/app/test-regex/main.c
+++ b/app/test-regex/main.c
@@ -173,7 +173,7 @@ init_port(struct rte_mempool **mbuf_mp, uint32_t nb_jobs,
};
struct rte_regexdev_qp_conf qp_conf = {
.nb_desc = 1024,
- .qp_conf_flags = RTE_REGEX_QUEUE_PAIR_CFG_OOS_F,
+ .qp_conf_flags = 0,
};
int res = 0;
@@ -218,6 +218,8 @@ init_port(struct rte_mempool **mbuf_mp, uint32_t nb_jobs,
printf("Error, can't configure device %d.\n", id);
goto error;
}
+ if (info.regexdev_capa & RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F)
+ qp_conf.qp_conf_flags |= RTE_REGEX_QUEUE_PAIR_CFG_OOS_F;
res = rte_regexdev_queue_pair_setup(id, 0, &qp_conf);
if (res < 0) {
printf("Error, can't setup queue pair for device %d.\n",
--
2.28.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v1] app/regex: configure qp according to device capabilities
2020-10-20 9:10 [dpdk-dev] [PATCH v1] app/regex: configure qp according to device capabilities guyk
@ 2020-10-20 9:14 ` Ori Kam
2020-10-22 10:53 ` Ophir Munk
2020-11-03 0:40 ` Thomas Monjalon
0 siblings, 2 replies; 6+ messages in thread
From: Ori Kam @ 2020-10-20 9:14 UTC (permalink / raw)
To: guyk; +Cc: NBU-Contact-Thomas Monjalon, smadarf, dovrat, dev
Hi Guy,
> -----Original Message-----
> From: guyk@marvell.com <guyk@marvell.com>
> Sent: Tuesday, October 20, 2020 12:10 PM
> Subject: [PATCH v1] app/regex: configure qp according to device capabilities
>
> From: Guy Kaneti <guyk@marvell.com>
>
> configure qp with OOS according to device capabilities
> returned from rte_regexdev_info_get.
>
> Signed-off-by: Guy Kaneti <guyk@marvell.com>
> ---
> app/test-regex/main.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/app/test-regex/main.c b/app/test-regex/main.c
> index e6080b44b..3deaf3c80 100644
> --- a/app/test-regex/main.c
> +++ b/app/test-regex/main.c
> @@ -173,7 +173,7 @@ init_port(struct rte_mempool **mbuf_mp, uint32_t
> nb_jobs,
> };
> struct rte_regexdev_qp_conf qp_conf = {
> .nb_desc = 1024,
> - .qp_conf_flags = RTE_REGEX_QUEUE_PAIR_CFG_OOS_F,
> + .qp_conf_flags = 0,
> };
> int res = 0;
>
> @@ -218,6 +218,8 @@ init_port(struct rte_mempool **mbuf_mp, uint32_t
> nb_jobs,
> printf("Error, can't configure device %d.\n", id);
> goto error;
> }
> + if (info.regexdev_capa &
> RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F)
> + qp_conf.qp_conf_flags |=
> RTE_REGEX_QUEUE_PAIR_CFG_OOS_F;
> res = rte_regexdev_queue_pair_setup(id, 0, &qp_conf);
> if (res < 0) {
> printf("Error, can't setup queue pair for device %d.\n",
> --
> 2.28.0
Acked-by: Ori Kam <orika@nvidia.com>
Best,
Ori
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v1] app/regex: configure qp according to device capabilities
2020-10-20 9:14 ` Ori Kam
@ 2020-10-22 10:53 ` Ophir Munk
2020-10-22 10:57 ` Ophir Munk
2020-10-22 11:12 ` Guy Kaneti
2020-11-03 0:40 ` Thomas Monjalon
1 sibling, 2 replies; 6+ messages in thread
From: Ophir Munk @ 2020-10-22 10:53 UTC (permalink / raw)
To: Ori Kam, guyk; +Cc: NBU-Contact-Thomas Monjalon, smadarf, dovrat, dev
Hi Guy,
I could not find RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F defined in latest dpdk/main. As a result my compilation is broken.
Can you please assist?
Regards,
Ophir
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Ori Kam
> Sent: Tuesday, October 20, 2020 12:14 PM
> To: guyk@marvell.com
> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>;
> smadarf@marvell.com; dovrat@marvell.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1] app/regex: configure qp according to
> device capabilities
>
>
> Hi Guy,
>
> > -----Original Message-----
> > From: guyk@marvell.com <guyk@marvell.com>
> > Sent: Tuesday, October 20, 2020 12:10 PM
> > Subject: [PATCH v1] app/regex: configure qp according to device
> > capabilities
> >
> > From: Guy Kaneti <guyk@marvell.com>
> >
> > configure qp with OOS according to device capabilities returned from
> > rte_regexdev_info_get.
> >
> > Signed-off-by: Guy Kaneti <guyk@marvell.com>
> > ---
> > app/test-regex/main.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/app/test-regex/main.c b/app/test-regex/main.c index
> > e6080b44b..3deaf3c80 100644
> > --- a/app/test-regex/main.c
> > +++ b/app/test-regex/main.c
> > @@ -173,7 +173,7 @@ init_port(struct rte_mempool **mbuf_mp,
> uint32_t
> > nb_jobs,
> > };
> > struct rte_regexdev_qp_conf qp_conf = {
> > .nb_desc = 1024,
> > - .qp_conf_flags = RTE_REGEX_QUEUE_PAIR_CFG_OOS_F,
> > + .qp_conf_flags = 0,
> > };
> > int res = 0;
> >
> > @@ -218,6 +218,8 @@ init_port(struct rte_mempool **mbuf_mp,
> uint32_t
> > nb_jobs,
> > printf("Error, can't configure device %d.\n", id);
> > goto error;
> > }
> > + if (info.regexdev_capa &
> > RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F)
> > + qp_conf.qp_conf_flags |=
> > RTE_REGEX_QUEUE_PAIR_CFG_OOS_F;
> > res = rte_regexdev_queue_pair_setup(id, 0, &qp_conf);
> > if (res < 0) {
> > printf("Error, can't setup queue pair for device
> %d.\n",
> > --
> > 2.28.0
>
> Acked-by: Ori Kam <orika@nvidia.com>
> Best,
> Ori
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v1] app/regex: configure qp according to device capabilities
2020-10-22 10:53 ` Ophir Munk
@ 2020-10-22 10:57 ` Ophir Munk
2020-10-22 11:12 ` Guy Kaneti
1 sibling, 0 replies; 6+ messages in thread
From: Ophir Munk @ 2020-10-22 10:57 UTC (permalink / raw)
To: Ori Kam, guyk; +Cc: NBU-Contact-Thomas Monjalon, smadarf, dovrat, dev
Please ignore.
Now I notice it in a follow up commit.
http://patches.dpdk.org/patch/81673/
> -----Original Message-----
> From: Ophir Munk
> Sent: Thursday, October 22, 2020 1:53 PM
> To: Ori Kam <orika@nvidia.com>; guyk@marvell.com
> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>;
> smadarf@marvell.com; dovrat@marvell.com; dev@dpdk.org
> Subject: RE: [PATCH v1] app/regex: configure qp according to device
> capabilities
>
> Hi Guy,
> I could not find RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F defined in latest
> dpdk/main. As a result my compilation is broken.
> Can you please assist?
>
> Regards,
> Ophir
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v1] app/regex: configure qp according to device capabilities
2020-10-22 10:53 ` Ophir Munk
2020-10-22 10:57 ` Ophir Munk
@ 2020-10-22 11:12 ` Guy Kaneti
1 sibling, 0 replies; 6+ messages in thread
From: Guy Kaneti @ 2020-10-22 11:12 UTC (permalink / raw)
To: Ophir Munk, Ori Kam
Cc: NBU-Contact-Thomas Monjalon, Smadar Fuks, Dovrat Zifroni, dev
Hi,
The patch was not merged yet:
https://patches.dpdk.org/patch/81673/
I will rebase this patch once it is merged.
Regards,
Guy
> -----Original Message-----
> From: Ophir Munk <ophirmu@nvidia.com>
> Sent: Thursday, October 22, 2020 1:53 PM
> To: Ori Kam <orika@nvidia.com>; Guy Kaneti <guyk@marvell.com>
> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Smadar Fuks
> <smadarf@marvell.com>; Dovrat Zifroni <dovrat@marvell.com>;
> dev@dpdk.org
> Subject: [EXT] RE: [PATCH v1] app/regex: configure qp according to device
> capabilities
>
> External Email
>
> ----------------------------------------------------------------------
> Hi Guy,
> I could not find RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F defined in
> latest dpdk/main. As a result my compilation is broken.
> Can you please assist?
>
> Regards,
> Ophir
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Ori Kam
> > Sent: Tuesday, October 20, 2020 12:14 PM
> > To: guyk@marvell.com
> > Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>;
> > smadarf@marvell.com; dovrat@marvell.com; dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v1] app/regex: configure qp according
> > to device capabilities
> >
> >
> > Hi Guy,
> >
> > > -----Original Message-----
> > > From: guyk@marvell.com <guyk@marvell.com>
> > > Sent: Tuesday, October 20, 2020 12:10 PM
> > > Subject: [PATCH v1] app/regex: configure qp according to device
> > > capabilities
> > >
> > > From: Guy Kaneti <guyk@marvell.com>
> > >
> > > configure qp with OOS according to device capabilities returned from
> > > rte_regexdev_info_get.
> > >
> > > Signed-off-by: Guy Kaneti <guyk@marvell.com>
> > > ---
> > > app/test-regex/main.c | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/app/test-regex/main.c b/app/test-regex/main.c index
> > > e6080b44b..3deaf3c80 100644
> > > --- a/app/test-regex/main.c
> > > +++ b/app/test-regex/main.c
> > > @@ -173,7 +173,7 @@ init_port(struct rte_mempool **mbuf_mp,
> > uint32_t
> > > nb_jobs,
> > > };
> > > struct rte_regexdev_qp_conf qp_conf = {
> > > .nb_desc = 1024,
> > > - .qp_conf_flags = RTE_REGEX_QUEUE_PAIR_CFG_OOS_F,
> > > + .qp_conf_flags = 0,
> > > };
> > > int res = 0;
> > >
> > > @@ -218,6 +218,8 @@ init_port(struct rte_mempool **mbuf_mp,
> > uint32_t
> > > nb_jobs,
> > > printf("Error, can't configure device %d.\n", id);
> > > goto error;
> > > }
> > > + if (info.regexdev_capa &
> > > RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F)
> > > + qp_conf.qp_conf_flags |=
> > > RTE_REGEX_QUEUE_PAIR_CFG_OOS_F;
> > > res = rte_regexdev_queue_pair_setup(id, 0, &qp_conf);
> > > if (res < 0) {
> > > printf("Error, can't setup queue pair for device
> > %d.\n",
> > > --
> > > 2.28.0
> >
> > Acked-by: Ori Kam <orika@nvidia.com>
> > Best,
> > Ori
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v1] app/regex: configure qp according to device capabilities
2020-10-20 9:14 ` Ori Kam
2020-10-22 10:53 ` Ophir Munk
@ 2020-11-03 0:40 ` Thomas Monjalon
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2020-11-03 0:40 UTC (permalink / raw)
To: guyk; +Cc: dev, smadarf, dovrat, Ori Kam
> > From: Guy Kaneti <guyk@marvell.com>
> >
> > configure qp with OOS according to device capabilities
> > returned from rte_regexdev_info_get.
> >
> > Signed-off-by: Guy Kaneti <guyk@marvell.com>
>
> Acked-by: Ori Kam <orika@nvidia.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-11-03 0:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-20 9:10 [dpdk-dev] [PATCH v1] app/regex: configure qp according to device capabilities guyk
2020-10-20 9:14 ` Ori Kam
2020-10-22 10:53 ` Ophir Munk
2020-10-22 10:57 ` Ophir Munk
2020-10-22 11:12 ` Guy Kaneti
2020-11-03 0:40 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).