From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 82DBB1B22E
 for <dev@dpdk.org>; Wed, 25 Oct 2017 14:13:26 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id C1AEB225F0;
 Wed, 25 Oct 2017 08:13:25 -0400 (EDT)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Wed, 25 Oct 2017 08:13:25 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=OU+K5XzFmHSOaI8AJHC2BULdVv
 HHxapQb1zI0+HOkw4=; b=VrSrjOn4d7oqyWuItagOT5tXPwnwZu0CYsACQXLixt
 jpBCfvykknM2dj0UqXBlDh6o0wkWRklAyBxKShZPoOjau8cxtNjUOpuw07O2+n+4
 qttfPJTcxtVxPRXH9wFwdN9E+jrvnPv0p7Dj2xwvbb10xF9qq4R5VeL0McATwTrz
 Q=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=OU+K5X
 zFmHSOaI8AJHC2BULdVvHHxapQb1zI0+HOkw4=; b=nLqd1Kah2mdWkM9BcN3jNH
 zFOvZROp3zd+1USwpX/0J665zgWJHAaePYgE6DUtuQMAecHVwdzIIRu4r5I3EuO7
 xy5Drvn2ZYpuWRGjzZnRTmD1rLDG5gSTobFE05WEhMTrjR99nXwBTMPcr4pCLfax
 D/gTZtt93aD1zg+u5FWmF0DZ1vX09o1IS2SKXdOJt4tEgvaEle819jNtIX2q5gaX
 +o8GiCJoRdxP/HU8ZlLXZjBqB28wO23xO70vUamlwrAi3mlc44m+ZercPiv5ly3y
 lmhhD1CzntarK8FmfnDrRDMy6UeqjsRqQGwXvL6VIhjNv+04iG63u3c57+0LyWCw
 ==
X-ME-Sender: <xms:5X_wWayeON_hrUlKm-zvcYm3Gplyp5qW4sVhxar5CID1vrXHH3C7cA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 71D7D24009;
 Wed, 25 Oct 2017 08:13:25 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Cc: dev@dpdk.org, "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>, "Dumitrescu,
 Cristian" <cristian.dumitrescu@intel.com>,
 "adrien.mazarguil@6wind.com" <adrien.mazarguil@6wind.com>, "Singh,
 Jasvinder" <jasvinder.singh@intel.com>
Date: Wed, 25 Oct 2017 14:13:24 +0200
Message-ID: <2175097.6NP1zJMmBs@xps>
In-Reply-To: <8CEF83825BEC744B83065625E567D7C24E057846@IRSMSX108.ger.corp.intel.com>
References: <1508771778-617-1-git-send-email-bernard.iremonger@intel.com>
 <2366771.cLq7VtfpKK@xps>
 <8CEF83825BEC744B83065625E567D7C24E057846@IRSMSX108.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v11 1/4] flow_classify: add flow classify
	library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Oct 2017 12:13:26 -0000

25/10/2017 13:10, Iremonger, Bernard:
> Hi Thomas,
> 
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 24/10/2017 19:28, Bernard Iremonger:
> > >  #
> > > +# Compile librte_classify
> > > +#
> > > +CONFIG_RTE_LIBRTE_FLOW_CLASSIFY=y
> > > +CONFIG_RTE_LIBRTE_CLASSIFY_DEBUG=n
> > 
> > The debug option is still there but seems not used.
> > I guess I can remove it?
> 
> The debug option is used  in rte_flow_classify.c at line 158.
> It needs  to be restored.
> Will I send a patch or can you restore it?

No, the intent is to stop adding some debug options in the config.

It is used in this lib to dump some data.
I think it should be triggered dynamically with the log level.