From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) by dpdk.org (Postfix) with ESMTP id EFC045691 for ; Thu, 26 Feb 2015 11:57:58 +0100 (CET) Received: by wesq59 with SMTP id q59so9480289wes.1 for ; Thu, 26 Feb 2015 02:57:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=y3GzfucJmS61NEYlSWkoq22F95/1TyqSPoucRPGLFL4=; b=SNsTuv7aD+EKXU/ugL/axzpva7WzmTlBOz4ISSbA6O9QXpLMvOO8IKpwd6LmgdQNaL XNdXVhft2IuBlM8Gvj+/J5BmU8aMH9nN6Kg0aQ+M70DM4OUrF0TepITnQhagmK68CurT DEovlx+Sz3qGOPsDDT1LoHz9ftEUuWyl6nVaPVoJ0bnt9+rXzpUCCSqaIDthkhTbVSms I9jnRKqoYMqSF1q8IemjoJzkgueddO/qRKOGnoJd47ui/bZbiZZEsvOJQooqWQJcHDAp LwtmYQmGQUMW7qo7DWf01zcaPAxpe4tz6n4LFDW4krBzdn3MwyBBo5eB/pjh4KlZQKqn j8pg== X-Gm-Message-State: ALoCoQmAAj5vGEulS3KU7uH9NoOhV2i6Hvv4zOUDY1GVa+/N/Oj9hb9NoGujSvsVI2tSHMv/xrrs X-Received: by 10.194.108.162 with SMTP id hl2mr14965148wjb.81.1424948278752; Thu, 26 Feb 2015 02:57:58 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id m4sm2235436wik.20.2015.02.26.02.57.57 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Feb 2015 02:57:57 -0800 (PST) From: Thomas Monjalon To: Tetsuya Mukawa Date: Thu, 26 Feb 2015 11:57:23 +0100 Message-ID: <2176123.7naUroNpz4@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: References: <1424414516-18609-1-git-send-email-mukawa@igel.co.jp> <3153139.jQ5sXg5pox@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v11 2/2] librte_pmd_null: Support port hotplug function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Feb 2015 10:57:59 -0000 2015-02-26 18:06, Tetsuya Mukawa: > 2015-02-26 16:03 GMT+09:00 Thomas Monjalon : > > 2015-02-25 16:49, Stephen Hemminger: > >> Build fails if HOTPLUG is disabled > > Hi Stephen, > > I appreciate for you reporting. > > > > > OK thanks for reporting. > > Actually there is no good reason to disable hotplug on Linux. > > Though it means that it's impossible to build on FreeBSD. > > > > Tetsuya, the right fix is to remove this option. > > Hi Thomas, > > Yes, I agree with it. I will add some codes to remove the option. > Please let me have a few days, I need to prepare BSD machine for compile test. > > > You should manage to graceful degrades hotplug in not supported > > cases supported: devices cannot be detachable in case of VFIO or nic_uio. > > What about uio_pci_generic? > > We cannot detach a vfio device so far. But we can detach a igb_uio and > uio_pci_generic device. > About a vfio ddevice, I haven't checked related code yet, but I guess > I will submit code to detach a vfio device in post-rc1. OK thanks. I made a quick fix (moving #ifdef) waiting the option removal: http://dpdk.org/browse/dpdk/commit/?id=7609e6609350