From: Thomas Monjalon <thomas@monjalon.net>
To: Bing Zhao <bingz@nvidia.com>
Cc: viacheslavo@nvidia.com, matan@nvidia.com, dev@dpdk.org,
orika@nvidia.com, rasland@nvidia.com, asafp@nvidia.com
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix wrong function of hairpin unbind
Date: Fri, 13 Nov 2020 20:09:30 +0100 [thread overview]
Message-ID: <2176186.QZRYtJoNy7@thomas> (raw)
In-Reply-To: <1605251133-325948-1-git-send-email-bingz@nvidia.com>
13/11/2020 08:05, Bing Zhao:
> In the implementation of mlx5_hairpin_unbind, a copy-paste error was
> inside. If a single peer Rx port needed to be unbound, it would be
> bound again by mistake.
>
> All the hardware resources were released when stopping the device and
> no mess of the configuration was introduced. But when trying to unbind
> the ports again, the issue would appear.
>
> The typo of the function call is fixed. If there is no hairpin queue
> bound between two ports, the unbinding process should be considered
> successful.
>
> Fixes: 37cd4501e873 ("net/mlx5: support two ports hairpin mode")
>
> Signed-off-by: Bing Zhao <bingz@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Applied in next-net-mlx, thanks.
prev parent reply other threads:[~2020-11-13 19:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 7:05 Bing Zhao
2020-11-13 19:09 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2176186.QZRYtJoNy7@thomas \
--to=thomas@monjalon.net \
--cc=asafp@nvidia.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).