[dpdk-dev] [PATCH] net/mlx5: fix wrong function of hairpin unbind

[dpdk-dev] [PATCH] net/mlx5: fix wrong function of hairpin unbind

[Bing Zhao]

In the implementation of mlx5_hairpin_unbind, a copy-paste error was
inside. If a single peer Rx port needed to be unbound, it would be
bound again by mistake.

All the hardware resources were released when stopping the device and
no mess of the configuration was introduced. But when trying to unbind
the ports again, the issue would appear.

The typo of the function call is fixed. If there is no hairpin queue
bound between two ports, the unbinding process should be considered
successful.

Fixes: 37cd4501e873 ("net/mlx5: support two ports hairpin mode")

Signed-off-by: Bing Zhao <bingz@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
 drivers/net/mlx5/mlx5_trigger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c
index 46e4191..bd02915 100644
--- a/drivers/net/mlx5/mlx5_trigger.c
+++ b/drivers/net/mlx5/mlx5_trigger.c
@@ -934,7 +934,7 @@
 				return ret;
 		}
 	else
-		ret = mlx5_hairpin_bind_single_port(dev, rx_port);
+		ret = mlx5_hairpin_unbind_single_port(dev, rx_port);
 	return ret;
 }
 
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH] net/mlx5: fix wrong function of hairpin unbind

[Thomas Monjalon]

13/11/2020 08:05, Bing Zhao:
> In the implementation of mlx5_hairpin_unbind, a copy-paste error was
> inside. If a single peer Rx port needed to be unbound, it would be
> bound again by mistake.
> 
> All the hardware resources were released when stopping the device and
> no mess of the configuration was introduced. But when trying to unbind
> the ports again, the issue would appear.
> 
> The typo of the function call is fixed. If there is no hairpin queue
> bound between two ports, the unbinding process should be considered
> successful.
> 
> Fixes: 37cd4501e873 ("net/mlx5: support two ports hairpin mode")
> 
> Signed-off-by: Bing Zhao <bingz@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

Applied in next-net-mlx, thanks.