Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

[Thomas Monjalon <thomas@monjalon.net>]

08/11/2019 14:16, Zhang, Qi Z:
> From: Ori Kam <orika@mellanox.com>
> > 
> > Yes missed somehow 6.
> > One more general comment, what happened until now? The Mark is already
> > implemented and working more then 2 years.
> 
> Actually we get many complain on i40e driver does not support MARK due to vector path is selected by default
> The driver always need a hint to select the mark aware data path by "--pkt-filter-mode =perfect" which is just a workaround.
> though this issue has been finally solved since software mark on vPMD is enabled recently on i40e.
> but For the new ice driver, we didn't get chance to enable this on vPMD yet, then we meet the same issue.

Qi, Intel knows the issue for a long time.
Did Intel helped with dynamic mbuf (part of the solution)?
Did Intel helped with this ethdev change?

In general, doing some PMD workaround instead of discussing API change is bad.
That's the same story for the VF config via representor, etc.
The way Intel was pushing some API which were not generic at all is also bad.
I really believe it's time to have truly generic API for all needs.
Speaking about that, we need a lot of cleanups in ethdev to remove some
vendor-specific bits and find generic replacements.

Qi, please don't take it personnaly, I am happy you enter in the discussion,
it is a good sign that we can do API improvements during next year.
I am motivated to address all ethdev issues before the next LTS 20.11.