Re: [dpdk-dev] [PATCH v1 01/16] ethdev: update ABI for flow API functions

[Thomas Monjalon <thomas@monjalon.net>]

05/04/2018 14:44, Adrien Mazarguil:
> On Thu, Apr 05, 2018 at 12:06:10PM +0200, Thomas Monjalon wrote:
> > 04/04/2018 17:56, Adrien Mazarguil:
> > > Subsequent patches will modify existing types and slightly alter the
> > > behavior of the flow API. This warrants a major ABI breakage.
> > > 
> > > While it is already taken care of for 18.05 (LIBABIVER was updated to
> > > version 9 by a prior commit), this patch explicitly adds the affected flow
> > > API functions as a safety measure.
> > 
> > I don't understand this patch.
> > 
> > If the API is broken, you must move the function from old block to
> > the new one.
> 
> Missed that part, I'll update it.
> 
> > And it must be done in the patch modifying the function.
> 
> About that, almost each patch in this series breaks the ABI in its own
> way. This left me with two options: either updating these functions once and
> for all and explaining why in a dedicated patch, or updating them in the
> first patch with an ABI impact, with subsequent patches piggybacking on that
> change.
> 
> Unless there's a way to update the map file for each patch that breaks ABI,
> I think the former is more consistent, but I don't mind if you prefer the
> latter. What do you suggest?

The ABI information must be updated when breaking (2nd solution).