From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id CE41B1CACD for ; Thu, 5 Apr 2018 15:36:32 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 67EE9213F8; Thu, 5 Apr 2018 09:36:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 05 Apr 2018 09:36:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=X+NRJrQoz45KRtv9TOz9aj7FMr UlEKviGFpHPDh6zx0=; b=Cvz+KNzuw1yGp/179UiHYAQNLXMW1g29ltiUu0TuJX zkhvxuaEfiCm/FXoNxbiUD1s8k2cZMTvPXiQxVmRYYrqqT+rQjJ7nO/sA3Umqu6a HlV1KU7+HOCXhyOFd6FG4cwI3CeIe5wjZcmQ+8TzFIsbAPY1oeuFtrxttcaLXoa7 4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=X+NRJr Qoz45KRtv9TOz9aj7FMrUlEKviGFpHPDh6zx0=; b=KpKccleK97Zx5nsSYJ5QYt RtDAIE1nvW+tvGzwzgnDsmQyXMImX5ykfShGj4lfzwkrTOWbbyt4tBZ+gNHaNlHN hRS9i0XbwzxQekuiPCASNHxLNNJBc2W5Vyr6WxpAjnseS0uTeOu2BhHSa+Md5KtQ cQTID4uNTdDAxWLcI1/a5q5WippLPfREVBYjuu+xL3nQ68Ejow+wDSR1aqAQWQ56 UOT8h2Odtkn2rNbrs+b9HwyHgpMm+8CG3FmnbcHrHq2gihUVon0MTGjElEJP/UUI uV15aHWvSX0X5ar+2DVO2twxp2yUF3P+/SxuR0SPxbag27UffFT9iJwdme/ma+XA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DF612E4449; Thu, 5 Apr 2018 09:36:30 -0400 (EDT) From: Thomas Monjalon To: Adrien Mazarguil Cc: dev@dpdk.org, Ferruh Yigit Date: Thu, 05 Apr 2018 15:36:30 +0200 Message-ID: <21769249.YhaxFZ1arZ@xps> In-Reply-To: <20180405124450.GL4957@6wind.com> References: <20180404150312.12304-1-adrien.mazarguil@6wind.com> <2170144.NMypU1fd1R@xps> <20180405124450.GL4957@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 01/16] ethdev: update ABI for flow API functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2018 13:36:33 -0000 05/04/2018 14:44, Adrien Mazarguil: > On Thu, Apr 05, 2018 at 12:06:10PM +0200, Thomas Monjalon wrote: > > 04/04/2018 17:56, Adrien Mazarguil: > > > Subsequent patches will modify existing types and slightly alter the > > > behavior of the flow API. This warrants a major ABI breakage. > > > > > > While it is already taken care of for 18.05 (LIBABIVER was updated to > > > version 9 by a prior commit), this patch explicitly adds the affected flow > > > API functions as a safety measure. > > > > I don't understand this patch. > > > > If the API is broken, you must move the function from old block to > > the new one. > > Missed that part, I'll update it. > > > And it must be done in the patch modifying the function. > > About that, almost each patch in this series breaks the ABI in its own > way. This left me with two options: either updating these functions once and > for all and explaining why in a dedicated patch, or updating them in the > first patch with an ABI impact, with subsequent patches piggybacking on that > change. > > Unless there's a way to update the map file for each patch that breaks ABI, > I think the former is more consistent, but I don't mind if you prefer the > latter. What do you suggest? The ABI information must be updated when breaking (2nd solution).