From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 9BF3F2BF4; Thu, 9 Aug 2018 18:16:55 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3598721B88; Thu, 9 Aug 2018 12:16:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 09 Aug 2018 12:16:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=ycgbFnOiUBgVQZ4tCUXtgieHhi hxkPhTyrrJBEiOARo=; b=U69WKTgAzmC5x3lSLx72bjYY81wy+LIv7xbnVqHgEZ FI54sZw3q/8a5n9+NsX7S1TyBxB3NBT50h6aWUw0x92P3c/fn7H9I6uhE5KwdHPz i9QCYPReLcU2Qe8zlSWZGVxMjUoE7Byrsbw1oJeSXB2sr18cd7CnCQgPRzuiko4H s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=ycgbFn OiUBgVQZ4tCUXtgieHhihxkPhTyrrJBEiOARo=; b=iQRenlXPehQBfqKC7gxfle vlbNlHpwPIiiqHt7tlRYON89gnqsaNYppyyqRnDAvA6x+BU1g0kVBiINg0r9viuK NcwsbsSIG/7fsZrih/8K1t8XOZEL2PujZ5EkgFcuMuYCZcxCx6WPgDmm9ndTQJre Bz5PxDzvLYcz4WqINbylHAypqWEsgRVC38rRVDdvAb5KFbAWgtzsdyo5m+Fcw0+T BC7k/WsinN8ox+htIm13LtmC0O5R/givPO0X7kArAmsU3x/mK55rDJuCi9Qe0Xqp HpMVffwvknyEWjT8mvtfuhwst8pH88rmzhPY2XDrjWj5zmNrB+8D1bRjH3dXkvzw == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114]) by mail.messagingengine.com (Postfix) with ESMTPA id 384C410289; Thu, 9 Aug 2018 12:16:54 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: stable@dpdk.org, dev@dpdk.org Date: Thu, 09 Aug 2018 18:16:53 +0200 Message-ID: <2177083.Ak4RRs4Y8F@xps> In-Reply-To: <20180809152235.45376-1-bruce.richardson@intel.com> References: <20180809152235.45376-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] mk: fix permissions when using make install X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 16:16:55 -0000 09/08/2018 17:22, Bruce Richardson: > When using make install, the permissions of the resulting file should be > those of the user using make install, not those of the user who ran the > build. This would not be the case when a user explicitly runs: > > "make && sudo make install" > > Fix this by changing "cp -a", which preserves all attributes, to > "cp -dR --preserve=timestamp", and by adding the flags > "--no-same-owner --no-same-permissions" to the calls to tar. > > Fixes: 1fa0fd9d6b42 ("mk: allow to specify DESTDIR in build rule") > Fixes: 6b62a72a70d0 ("mk: install a standard cutomizable tree") > Fixes: 576de42b83e5 ("doc: render and install man pages") > > CC: stable@dpdk.org > Signed-off-by: Bruce Richardson Acked-by: Thomas Monjalon Applied, thanks