From: Thomas Monjalon <thomas@monjalon.net>
To: Daniel Verkamp <daniel.verkamp@intel.com>
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH v2] pci: pad vendor and device ID to 4 digits
Date: Wed, 05 Jul 2017 15:16:44 +0200 [thread overview]
Message-ID: <2177838.ELAm1vN6DR@xps> (raw)
In-Reply-To: <20170623182032.28734-1-daniel.verkamp@intel.com>
23/06/2017 20:20, Daniel Verkamp:
> Some PCI vendor and device IDs have leading zeros.
>
> Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
> ---
> --- a/lib/librte_eal/common/include/rte_pci.h
> +++ b/lib/librte_eal/common/include/rte_pci.h
> @@ -68,6 +68,9 @@ const char *pci_get_sysfs_path(void);
> /** Short formatting string, without domain, for PCI device: Ex: 00:01.0 */
> #define PCI_SHORT_PRI_FMT "%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8
>
> +/** Formatting string for PCI vendor and device ID: Ex: 1234:5678 */
> +#define PCI_ID_PRI_FMT "%.4" PRIx16 ":%.4" PRIx16
Why not printing the whole PCI infos with domain and function?
Note: public macros should be prefixed with RTE_
prev parent reply other threads:[~2017-07-05 13:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 17:29 [dpdk-dev] [PATCH] " Daniel Verkamp
2017-06-23 17:44 ` Stephen Hemminger
2017-06-23 18:20 ` [dpdk-dev] [PATCH v2] " Daniel Verkamp
2017-07-05 13:16 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2177838.ELAm1vN6DR@xps \
--to=thomas@monjalon.net \
--cc=daniel.verkamp@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).