From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 95E5F5587 for ; Fri, 15 Jul 2016 23:30:55 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id o80so45707699wme.1 for ; Fri, 15 Jul 2016 14:30:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=oT83A1mMpzMjR2JZUN4QsjbeX4Pu2jeFXNk+N9eHN3k=; b=FUtyW2U+eqUzOv33s2yOfrs6cSbDgmYWo1iYe07ZWHKFoItls9QOFghBav18BXW/vp xs/JvBQLvbz1hNFhe4Y23x0n7NOexh3fEKq2qvhYfVy9gPm1Q4uxHrG1Hoc4VkaXEXCK Iuq8ru+tfzl8DIMNFrzKjWORntEhRQp8G7f9Afe0sWPLDayAsCsRL1msjC3AV5sfQZep WTz2LHtCy6vrtoNwjVDDhc+43LsifxgOr5ug/cP6redJj4TxUhIPx0OKpD5v2DyZwvqK V4NS5vU66ugT5/eT759dDO4XSHhzyivOfxdLbhe+PIgqGUzqle+SX4vMR0Tj58vu6ujT vQhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=oT83A1mMpzMjR2JZUN4QsjbeX4Pu2jeFXNk+N9eHN3k=; b=UFB+Yv+MJqwqovBMltztEm3PRT6C5sONiSdumwvWmlWhMDZSuXtnnz6hAX57DHZOBJ s/LIjKmB8G71slxKRaxhOi/Es5ntuLQbrgdFv/CNIcMK7fmqMb7PnWHGR1ywCz6M/ywe TU/NBrAfuaRywSKDYBBVSVHZHh0VRWVRqiBI3pM1ilUrqs0F+acYdU5RLLfzExlXhAq/ tgqrVxH93X3WC4j64KKZVEfNUlbGm67K8rqRV9MikmdKVe+ljB475tLpBGX84HCO7tzb Qy5AcbOyRsOMHAK+0KbeqIaPOXkfEvipY+GHPgbjC+n4U3YJ/reTwyB7m2uKsorHXbRR AA6g== X-Gm-Message-State: ALyK8tIr9uxFonvwm5/FNkZZUS4tXbDeICrtzFvo+RkUUIa6PvPjrfeaF26LXkimu8yRxgVV X-Received: by 10.194.179.166 with SMTP id dh6mr2786869wjc.140.1468618255423; Fri, 15 Jul 2016 14:30:55 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id aw4sm2595868wjc.49.2016.07.15.14.30.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Jul 2016 14:30:54 -0700 (PDT) From: Thomas Monjalon To: John Daley Cc: dev@dpdk.org, bruce.richardson@intel.com Date: Fri, 15 Jul 2016 23:30:53 +0200 Message-ID: <2178957.VeIBf3gLIC@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1468351487-12002-1-git-send-email-johndale@cisco.com> References: <1468351487-12002-1-git-send-email-johndale@cisco.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/enic: fix Tx and Rx queue stop and start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2016 21:30:55 -0000 2016-07-12 12:24, John Daley: > The exported device start and stop functions where not setting the queue > states to RTE_ETH_QUEUE_STATE_STARTED and RTE_ETH_QUEUE_STATE_STOPPED. > After starting the device, the RTE queue stop function would not call > the enic queue stop function since queue was already marked as stopped. > > Put queue state updates in the lower level queue start/stop functions > which are called by both device and queue start/stop functions. > > Fixes: fefed3d1e62c ("enic: new driver") > > Reviewed-by: Nelson Escobar > Signed-off-by: John Daley Applied, thanks