From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 6F3295688 for ; Fri, 27 Jul 2018 15:46:48 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 7843E40009E; Fri, 27 Jul 2018 13:46:47 +0000 (UTC) Received: from [192.168.1.16] (85.187.13.33) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Fri, 27 Jul 2018 14:46:42 +0100 To: Thomas Monjalon CC: , Olivier Matz References: <1531306750-9844-1-git-send-email-arybchenko@solarflare.com> <5677276.1WdofzzUsl@xps> From: Andrew Rybchenko Message-ID: <217aa1df-7b7e-bad0-2db5-928349b018cc@solarflare.com> Date: Fri, 27 Jul 2018 16:45:47 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <5677276.1WdofzzUsl@xps> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [85.187.13.33] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-23994.003 X-TM-AS-Result: No-7.381200-8.000000-10 X-TMASE-MatchedRID: pBwXUM+nCwsOwH4pD14DsPHkpkyUphL9h+w9Wz/xXDogFpRK4NVZT1m1 X5/fQB63upmFh/oXlkTXI0lAa5ksXkMpVZZsZyZGiS8eKdD/7uQxXH/dlhvLv4KwF4K/wIz9+FP r+ke82knRrJQOGoEbV5GTpe1iiCJq71zr0FZRMbALbigRnpKlKWxlRJiH4397UNJnxU1khuYfj/ c4KFHzbGuPT9jlfwJxWwpiV9Dla6jk9wc+wNozxw== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--7.381200-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-23994.003 X-MDID: 1532699208-0vQ5jvlbFyOH Subject: Re: [dpdk-dev] [PATCH 1/2] mempool: remove deprecated functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 13:46:48 -0000 On 27.07.2018 00:34, Thomas Monjalon wrote: > 11/07/2018 12:59, Andrew Rybchenko: >> Functions rte_mempool_populate_phys(), rte_mempool_virt2phy() and >> rte_mempool_populate_phys_tab() are just wrappers for corresponding >> IOVA functions and were deprecated in v17.11. >> >> Functions rte_mempool_xmem_create(), rte_mempool_xmem_size(), >> rte_mempool_xmem_usage() and rte_mempool_populate_iova_tab() were >> deprecated in v18.05 and removal was announced earlier in v18.02. >> >> Signed-off-by: Andrew Rybchenko >> --- >> lib/librte_mempool/Makefile | 3 - >> lib/librte_mempool/meson.build | 4 - >> lib/librte_mempool/rte_mempool.c | 181 +-------------------- >> lib/librte_mempool/rte_mempool.h | 179 -------------------- >> lib/librte_mempool/rte_mempool_version.map | 6 - >> 5 files changed, 1 insertion(+), 372 deletions(-) > Please update the release notes, deprecation notice, and bump ABI version. Will do. Deprecation notice which schedules removal of xmem functions was removed on previous release when these function are deprecated. Is it a problem? Should removal of already deprecated function pass deprecation (removal) announcement procedure once again? Andrew.