From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 437BD590F for ; Thu, 17 Mar 2016 17:42:06 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id l68so34264694wml.0 for ; Thu, 17 Mar 2016 09:42:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=oyAdk2pAhhuL776JzBaMCGJWurzznwUdcnTJd3VnThk=; b=hutgj29T2yrmB6Y4LtIoHy0GPRHa22Um0df6aldJ+s64soLo5gQsUq/31J7Kc8aBku +dn7wkMjfOmo1tnBI4aEeCE0X5Aw4xtz8rjm6RoAY5fmKI/okN0JM29w/vt30PnmEn2E 2fsWwNRYXprORl1CU93iVwzUWVrrPWWHKdRaqFNBtQR/jS0/eOzqwZYvHWB6583v67Uw cr98HY+iW2PWvAdZV/a61+ohxjy3J2giMuQS6SgRAMONBGs4ZpLWFalV+4PAQUAk5Ige jDKz/Mdys1Fd3lJzPSEitOm9DTHZweNrutQmxwB4yJz54L1y/n5NlJ13VQeq2p/thPBX IcIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=oyAdk2pAhhuL776JzBaMCGJWurzznwUdcnTJd3VnThk=; b=eP9gJhFZG8qVDDMd03d3RH3g1nU81pcULZyN2uMZ0KwA9WHPn30T5HVEiYO1N/jIwW g3RsddrIigjcCFffTjYBEhUtZICDI8c8S/NOyCBPwMGmb7y3b9zcwHeVrN/kxoz7yNgX 6UPqjz1bVriQCDJ88asiIhpPjyaxI1GIkkG1c1V/4E7/0dygdftGUKrA8aqibSvbYaCW smCFalZsIfr9uXHgtDvFwokuRzloG9eMf3F/oJ8LEtnCvjf6+LMNonsR38ixh6Az+bA4 g+mfGPfvUQDYKwlrQ3zkRl+hDYUZwVH6WHtAgyKVF3X8ky6eMfMXVRLpYrq+qgG/UeEk b6sA== X-Gm-Message-State: AD7BkJJgP76EFGtvEEcPv+ba3k2CLCCfdl9dTwWHYBVxI8b/pXRcIo5r7ly5AEue/BeeOPMJ X-Received: by 10.28.11.69 with SMTP id 66mr12007723wml.103.1458232926108; Thu, 17 Mar 2016 09:42:06 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id i5sm8423468wja.23.2016.03.17.09.42.04 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 17 Mar 2016 09:42:04 -0700 (PDT) From: Thomas Monjalon To: Igor Ryzhov Cc: dev@dpdk.org, maryam.tahhan@intel.com, olivier.matz@6wind.com Date: Thu, 17 Mar 2016 17:40:35 +0100 Message-ID: <2180400.M1OUCR6DC3@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1457615010-87436-1-git-send-email-iryzhov@nfware.com> References: <1457615010-87436-1-git-send-email-iryzhov@nfware.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: don't count missed packets in erroneous packets counter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2016 16:42:06 -0000 CC Maryam and Olivier who had discussions about imissed and other stats: http://dpdk.org/ml/archives/dev/2015-August/022905.html http://dpdk.org/ml/archives/dev/2015-September/023351.html http://dpdk.org/ml/archives/dev/2015-September/023612.html 2016-03-10 16:03, Igor Ryzhov: > Comment for "ierrors" counter says that it counts erroneous received packets. But for some reason "imissed" counter is added to "ierrors" counter in most drivers. It is a mistake, because missed packets are obviously not received. This patch fixes it. According to this patch http://dpdk.org/browse/dpdk/commit/?id=70bdb186 imissed was kept in ierrors because of backward compatibility. I'm OK to remove imissed from ierrors. Fixes: 70bdb18657da ("ethdev: add Rx error counters for missed, badcrc and badlen packets") Fixes: 6bfe648406b5 ("i40e: add Rx error statistics") Fixes: 856505d303f4 ("cxgbe: add port statistics") Acked-by: Thomas Monjalon