From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E34541EB2; Thu, 16 Mar 2023 18:00:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F44440DF6; Thu, 16 Mar 2023 18:00:08 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id A992040DDC for ; Thu, 16 Mar 2023 18:00:06 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 58DC25C0162; Thu, 16 Mar 2023 13:00:06 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 16 Mar 2023 13:00:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1678986006; x=1679072406; bh=M0F7Ogw/qaCTAZAM2dznpmFMGTx2RuxjjfH WbHHoaqk=; b=TiB+J42eGnSZdH1KsFEeNpDA+OXV3VnbHpY/s6QkbcUdBSayrVu 9hTw77fpEKtAFkDF1ES2KkTEQNPYz04Xgpc5ea16JNqnYdBQAtigR5bo1igxHZ76 ghIovlJUNEF970HcSo4JeedLc+oE7LY+V1slUOoc0gBXNvpI1CcXAnu0kQRV28hA j338rDmHZ2hz8Z0DXqTkPqUTt+7qtYUO4REQL8xJgR29ih59zMwEZD5JzAEEeaWM ONWxuni60paJZK5W99IhXUEjH4Q0byVKnRapMHGv1CKJsKXi3N+n/IQMGlG+lFXP ox3CKQI2SbC5GIW9ENt27JEN1ZGJ7uM4gIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1678986006; x=1679072406; bh=M0F7Ogw/qaCTAZAM2dznpmFMGTx2RuxjjfH WbHHoaqk=; b=XwpXHyHJv21BWJuu2T/eK4cofvi/An1QW6McohnWXFvsTAUFJAe yG61aNXPU3Vp4Ah5ku6Im+83OvvMtA7kCtMUwC950tcIllN10GWebzvj0M6+HO81 mnSqvaD7IukdN+/Q0ZskyyvKk+37CcRQn1IaDdvrLXQff1oUbLu1cagFrnU57R4V /zLLsqGjbL3dhl5XBJ6E7wZqRBZ/Gv9x/HUdGJCgreMQAM3qZWYGsHMXnuCxqYTL K04VE4FClTixJ9khMkmAkRwE5Yhoz4ehOaDcGAF1t1qqfqVMMCDVnz/QQXtTqFo8 R7Qtv8Ufq6BcDEofsAkzrd9QG0AFBcdAjzw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeftddgleeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 Mar 2023 13:00:05 -0400 (EDT) From: Thomas Monjalon To: Srikanth Yalavarthi Cc: Prince Takkar , Shivah Shankar S , dev@dpdk.org, aprabhu@marvell.com Subject: Re: [PATCH v2 1/1] ml/cnxk: fix multiple coverity issues Date: Thu, 16 Mar 2023 18:00:04 +0100 Message-ID: <21806585.EfDdHjke4D@thomas> In-Reply-To: <20230316093341.18829-1-syalavarthi@marvell.com> References: <20230315135427.11489-1-syalavarthi@marvell.com> <20230316093341.18829-1-syalavarthi@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/03/2023 10:33, Srikanth Yalavarthi: > Added checks for null pointers. Removed logically dead code. > Fix division or modulo by zero. Fix evaluation order violation > issues. Fix potential memory leak in xstats function. I think it would be better to split this patch a little, so we can easily see what are the reasons for the changes.