From: Thomas Monjalon <thomas@monjalon.net>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twice
Date: Tue, 06 Nov 2018 21:36:22 +0100 [thread overview]
Message-ID: <2180900.HKzicAuZ6Y@xps> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E70611532E0279@SHSMSX103.ccr.corp.intel.com>
06/11/2018 16:46, Zhang, Qi Z:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> >
> > Hi,
> >
> > 06/11/2018 01:31, Qi Zhang:
> > > When probe the same device at second time
> >
> > Sorry I stop on this first sentence.
> > How and why do you probe a vdev twice?
>
> if we do rte_dev_hotplug_add or rte_dev_proble on a probed device. (yes, this is not usually what an application want, but it can happen by miss-operation, and this is covered by our test case, it make sense to me that hotplug API should be robust enough to handle that situation.)
Yes I agree we must handle this situation.
> we will failed at the second time as expected,
> but will not able to detach the device any more, since during the second scan, original vdev->device.devargs is corrupted.
The root cause is we remove a devargs which was referenced.
Could we overwrite the first devargs instead of removing it?
next prev parent reply other threads:[~2018-11-06 20:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 0:31 Qi Zhang
2018-11-06 8:53 ` Gaëtan Rivet
2018-11-06 9:00 ` Thomas Monjalon
2018-11-06 15:46 ` Zhang, Qi Z
2018-11-06 20:36 ` Thomas Monjalon [this message]
2018-11-06 23:33 ` Gaëtan Rivet
2018-11-07 16:53 ` Zhang, Qi Z
2018-11-07 17:15 ` Gaëtan Rivet
2018-11-07 17:46 ` Zhang, Qi Z
2018-11-12 0:50 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2180900.HKzicAuZ6Y@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).