From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Ido Barnea (ibarnea)" <ibarnea@cisco.com>
Cc: dev@dpdk.org, Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [dpdk-dev] [PATCH] Fill speed_capa for virtio
Date: Fri, 10 Feb 2017 09:41:26 +0100 [thread overview]
Message-ID: <2185375.0v2z51C3zP@xps13> (raw)
In-Reply-To: <C61299CA-E83A-41F3-ACEE-AB5E82C65122@cisco.com>
2017-02-10 07:49, Ido Barnea:
> On 09/02/2017, 6:19 PM, "Thomas Monjalon" <thomas.monjalon@6wind.com> wrote:
> >2017-02-02 12:05, Ido Barnea:
> >> From: Ido Barnea <ibarnea@cisco.com>
> >>
> >> Signed-off-by: Ido Barnea <ibarnea@cisco.com>
> >> ---
> >> drivers/net/virtio/virtio_ethdev.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> >> index d1ff234..1d572b5 100644
> >> --- a/drivers/net/virtio/virtio_ethdev.c
> >> +++ b/drivers/net/virtio/virtio_ethdev.c
> >> @@ -1869,6 +1869,7 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
> >> (1ULL << VIRTIO_NET_F_HOST_TSO6);
> >> if ((hw->guest_features & tso_mask) == tso_mask)
> >> dev_info->tx_offload_capa |= DEV_TX_OFFLOAD_TCP_TSO;
> >> + dev_info->speed_capa = ETH_LINK_SPEED_10G;
> >
> >Why 10G ?
> >Yuanhan, any opinion?
>
> Just wanted this to be consistent with below (From virtio_dev_link_update):
> link.link_speed = SPEED_10G;
OK, that's the kind of justification which are good to have in
the commit message.
next prev parent reply other threads:[~2017-02-10 8:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170202092357.58508-1-ibarnea@cisco.com>
2017-02-02 12:05 ` Ido Barnea (ibarnea)
2017-02-09 16:19 ` Thomas Monjalon
2017-02-10 7:49 ` Ido Barnea (ibarnea)
2017-02-10 8:41 ` Thomas Monjalon [this message]
2017-02-10 11:05 ` [dpdk-dev] [PATCH v2] net/virtio: add speed capability Thomas Monjalon
2017-02-10 11:06 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2185375.0v2z51C3zP@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ibarnea@cisco.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).