From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 0AE68201 for ; Fri, 10 Feb 2017 09:41:27 +0100 (CET) Received: by mail-wm0-f50.google.com with SMTP id v77so41793771wmv.0 for ; Fri, 10 Feb 2017 00:41:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=CNkS5l1gRaJSH2VeiZGgt/TXdllE/R0llJvUkzzVt2A=; b=zgeE/tBVvgGPHrHmz4gFt0LZTYhP2g2FoSu1rG5HzcHsLJyDeabAjz1HYqA7vZokTC 5jAXpT4bAfYnNhSKVb0PdtAxbMF4zwWZu9/JGPBy5urfUZDLyUyZYl7eHHjP3bt+8tCI WuHklFAwcuoG4YRFiNpkpGBxUGmAsrSOh6GsMhEllFCdjUOBilFtIuqyOjfYuP4SYhut Yie3vkudSPH3AcNKTE8jKIISkMj90RdWyTxLWPZJMq87oVgPGUVzYQEqyj+2+1LoWE2d TQCtPoQh1ZSRjujV7qI2QwcrIv45YvdoZ74XkAzk3MyRiG6JjDZDBGb4bWgyc7ZuD3tN 4lPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=CNkS5l1gRaJSH2VeiZGgt/TXdllE/R0llJvUkzzVt2A=; b=gpE0iBPzBd0v47GmDu6fTGO3UVEoIg4V24ZV6xljydE/uwuWvplE5inoIt1C/4CFg3 mWo2h1yVyAPp8VRTXHMfhbx0wvMjkslnYs28rX3gRQ8sqKTYxVEjRRWPrZwt3aK2ct8x vSTzUbzJWVaesDAOmH5aUP0sRwMAYjXKvQZVbbruQlf+v2U5Tnv2QDc4A6gSsXWLHQJN 7SjWPPk9auWlko+LWZIJc2PWexmGYKz3xFdfrhi5qFebCvOMl7Qik28nF5LLnh606Sfj FXwYYBWiWoZr80KvpV+7zNtnCchi8JyInWeqHt7pJw8FhXVe5EsgbB3ie+25p10DcBp5 LfKQ== X-Gm-Message-State: AMke39mN8JwnBHgqiswhH3hdlsxsva+YBK79prIaI6c91IUqFO6x0ml+Bo+ZdWaCrA8QHotk X-Received: by 10.28.71.220 with SMTP id m89mr23954689wmi.120.1486716087780; Fri, 10 Feb 2017 00:41:27 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id a35sm1571401wra.21.2017.02.10.00.41.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Feb 2017 00:41:27 -0800 (PST) From: Thomas Monjalon To: "Ido Barnea (ibarnea)" Cc: dev@dpdk.org, Yuanhan Liu Date: Fri, 10 Feb 2017 09:41:26 +0100 Message-ID: <2185375.0v2z51C3zP@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <20170202092357.58508-1-ibarnea@cisco.com> <1524443.RGCIa5yWyV@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] Fill speed_capa for virtio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Feb 2017 08:41:28 -0000 2017-02-10 07:49, Ido Barnea: > On 09/02/2017, 6:19 PM, "Thomas Monjalon" wrote: > >2017-02-02 12:05, Ido Barnea: > >> From: Ido Barnea > >> > >> Signed-off-by: Ido Barnea > >> --- > >> drivers/net/virtio/virtio_ethdev.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > >> index d1ff234..1d572b5 100644 > >> --- a/drivers/net/virtio/virtio_ethdev.c > >> +++ b/drivers/net/virtio/virtio_ethdev.c > >> @@ -1869,6 +1869,7 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > >> (1ULL << VIRTIO_NET_F_HOST_TSO6); > >> if ((hw->guest_features & tso_mask) == tso_mask) > >> dev_info->tx_offload_capa |= DEV_TX_OFFLOAD_TCP_TSO; > >> + dev_info->speed_capa = ETH_LINK_SPEED_10G; > > > >Why 10G ? > >Yuanhan, any opinion? > > Just wanted this to be consistent with below (From virtio_dev_link_update): > link.link_speed = SPEED_10G; OK, that's the kind of justification which are good to have in the commit message.