From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 7493B201
 for <dev@dpdk.org>; Fri, 23 Dec 2016 17:17:09 +0100 (CET)
Received: by mail-wm0-f46.google.com with SMTP id t79so216509120wmt.0
 for <dev@dpdk.org>; Fri, 23 Dec 2016 08:17:09 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=dB2OaZwMtriQ224tpTSsGgGq6sJy2zcLRfV9QpB/6Yk=;
 b=opf+5m9fYWBtOuMKe5Xl59V2BFqEnz2y8YKkBNL1992stIm77qbwpvbQuB0+8ZUj8l
 ZcP5MEB7M7i2Vl7DdVfM/UeoX++Sjq/sqwKDAPiN695F8ofSI38y0X0pHvI7gC5NYDhd
 r9W5foVQpiYd1c70W6Oq9B7vEE83gXFhDQ8bldVVHLDFVEg46aMWoU9TDs8Cc+rCOneS
 AiwEw5xPltiZlVJIixQqk/zkBl18msHJMUVby8Rcual/KXav+AjfS7BhDTfpIf6um01f
 4UqtliV3UT5K9yheZk0utdGhCpU0+IIS2WQdsy2KQJWR3YifXB3/b4YICEcgYVG4s/H0
 o70g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=dB2OaZwMtriQ224tpTSsGgGq6sJy2zcLRfV9QpB/6Yk=;
 b=gIFzsOTC04XmTWGfN+mKZO1tuBB6q++JFcwmNWnfudLS+9LuEMlb4MKvHWzd437M0O
 x26v1kSBaND3TvL8nZYBuTs1z6RzTW0dPFpd8BWceU47dArrKAvmn3jUxglDCwXugX3F
 BtfGgMOWijd2MeS+eVeQ0XiNx1Llsd656o/vr1echJfQVR3OOkhzoTCaZLo9rzVK7jCT
 pYEmh5YCwGz567E/Al9cK3jgqQpUgrRlLojUgALXbKgwDU53Pwof3E3gbZ+oVPOft33/
 EyC1K/y5X4bo9Gp4fPPmSjCN5aD9AVKExo3gGZVWtTFPQYB3qJTD5lcgeDquWsUFHwbA
 zEOg==
X-Gm-Message-State: AIkVDXIIsM+nAb3YYX2KJQeYGZ8DydUFFCZ5d0tWXFvsA5Aqv1UMydh9gUyXkPi2U+zqdYYW
X-Received: by 10.28.4.146 with SMTP id 140mr11675283wme.60.1482509829239;
 Fri, 23 Dec 2016 08:17:09 -0800 (PST)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id 135sm37839463wmh.14.2016.12.23.08.17.08
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 23 Dec 2016 08:17:08 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jan Blunck <jblunck@infradead.org>
Cc: dev@dpdk.org, shreyansh.jain@nxp.com, david.marchand@6wind.com,
 stephen@networkplumber.org
Date: Fri, 23 Dec 2016 17:17:07 +0100
Message-ID: <2185678.prfkkk662h@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1482508691-11408-21-git-send-email-jblunck@infradead.org>
References: <1482508691-11408-1-git-send-email-jblunck@infradead.org>
 <1482508691-11408-21-git-send-email-jblunck@infradead.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v5 20/20] ethdev: Decouple from PCI device
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Dec 2016 16:17:09 -0000

2016-12-23 16:58, Jan Blunck:
> +/**
> + * @internal
> + * Helper macro for drivers that need to convert to struct rte_pci_device.
> + */
> +#define RTE_DEV_PCI_DEV(ptr) container_of(ptr, struct rte_pci_device, device)

Do you prefer to rename to RTE_DEV_TO_PCI?

> +       struct rte_device *device; /**< Backing device for this device */

This comment looks strange.
shorten to just "Backing device"?