From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CA99A0A0C; Thu, 22 Jul 2021 21:46:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 426F04014D; Thu, 22 Jul 2021 21:46:18 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 3D4BD40040 for ; Thu, 22 Jul 2021 21:46:17 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 4E0E432000EB; Thu, 22 Jul 2021 15:46:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 22 Jul 2021 15:46:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= hFvNcLnpC+nMImZkv+7av4qrnSw2Cwz3G3JnMOVVtyM=; b=Do1TizM0WQq5Fs6i uQxuK+F3ZFyOwEVZk5v7Yl+eYwLej9j06i96QaDzTA0rVYNU5lLA5YmLpCagPWfT QChF3kkROqmYng+5KODUoUl//4WFRhLAGwLPvIxQOenTerP2DnI898R4Hz/uMbjd U/aYNUdGi0KOX/yd813qHCjCS2yIYya11aRhJGVbcTZmUk3MmN9LzSLenI3t4t8y EEk0r4c8VaqjDtEws2WOMjXRbKDTXhkuu59dwiXmZiXBglVsn/xzb/2jOv3b2l1E /tpzW4v5QJ+mHMIUeimHTx4UbiVvBYg7IEGODHXr8xFuR5q3Z9paMyeKWt9Hrnnu QOA7mA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=hFvNcLnpC+nMImZkv+7av4qrnSw2Cwz3G3JnMOVVt yM=; b=Bod9PzPjfrMuoeXRJixWZCB0ENMic8nRgx5QxJkj2jwPzmBhVhzes24JC KrqGq6DTtt08/tyeBc6m9Qkeza9d+TL1TpAgML/KpeeXIVE1XV7yi+TAh82pf1qN 9KYWsbnTDcaN51AoICkKUGGesqlWUEF5e/ofnKER+yuY5XLkAqOTAvtSEVhRW5ZP 1eNMAexwgXJMgQM+BUOGudQT4gLlDCnIKaX/1pUC/5EvRr1xihKlvtRQ9Hl1jogh 8lS5WNQy2cPNrXcj9MwFSHl4WyT9nJheD4b5ILz5KqKNIKtRWuRvpSCfXnNwEf0V QT+KqXduTJDlU6nC65aCG13FDFPLQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrfeeigddufedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Jul 2021 15:46:13 -0400 (EDT) From: Thomas Monjalon To: Kevin Traynor Cc: dev@dpdk.org, mdr@ashroe.eu Date: Thu, 22 Jul 2021 21:46:32 +0200 Message-ID: <2185865.z788A1Ek0O@thomas> In-Reply-To: <20210709151938.701895-1-ktraynor@redhat.com> References: <20210709151938.701895-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/3] bitrate: change reg implementation to match API description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/07/2021 17:19, Kevin Traynor: > rte_stats_bitrate_reg() API states it returns 'Zero on success'. > > However, the implementation directly returns the return of > rte_metrics_reg_names() which may be zero or positive on success, > with a positive value also indicating the index. > > The user of rte_stats_bitrate_reg() should not care about the > index as it is stored in the opaque rte_stats_bitrates struct. > > Change the implementation of rte_stats_bitrate_reg() to match > the API description by always returning zero on success. > > Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library") > > Signed-off-by: Kevin Traynor Does it require a deprecation notice? At least I suggest a release note in API section. What is the target for this series? 21.11?