* [dpdk-dev] [PATCH] test/eventdev: update the port id to 16 bit
@ 2018-05-15 15:48 Vipin Varghese
2018-05-15 10:23 ` Rao, Nikhil
2018-05-15 18:06 ` [dpdk-dev] [PATCH v2] " Vipin Varghese
0 siblings, 2 replies; 5+ messages in thread
From: Vipin Varghese @ 2018-05-15 15:48 UTC (permalink / raw)
To: dev, nikhil.rao, deepak.k.jain; +Cc: Vipin Varghese
port id in test case is update to unsigned int 16 bit, to
prvent compilation faulure when RTE_ETH_MAX port is set more
than 255.
Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
---
test/test/test_event_eth_rx_adapter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/test/test_event_eth_rx_adapter.c b/test/test/test_event_eth_rx_adapter.c
index ab55398..dee632b 100644
--- a/test/test/test_event_eth_rx_adapter.c
+++ b/test/test/test_event_eth_rx_adapter.c
@@ -107,7 +107,7 @@ port_init(uint8_t port, struct rte_mempool *mp)
static int
init_ports(int num_ports)
{
- uint8_t portid;
+ uint16_t portid;
int retval;
default_params.mp = rte_pktmbuf_pool_create("packet_pool",
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] test/eventdev: update the port id to 16 bit
2018-05-15 15:48 [dpdk-dev] [PATCH] test/eventdev: update the port id to 16 bit Vipin Varghese
@ 2018-05-15 10:23 ` Rao, Nikhil
2018-05-15 12:24 ` Varghese, Vipin
2018-05-15 18:06 ` [dpdk-dev] [PATCH v2] " Vipin Varghese
1 sibling, 1 reply; 5+ messages in thread
From: Rao, Nikhil @ 2018-05-15 10:23 UTC (permalink / raw)
To: Vipin Varghese, dev, deepak.k.jain; +Cc: nikhil.rao
On 5/15/2018 9:18 PM, Vipin Varghese wrote:
> port id in test case is update to unsigned int 16 bit, to
> prvent compilation faulure when RTE_ETH_MAX port is set more
^^^^^^^ ^^^^^^^ ^^^^^^^^^^^^^^^
prevent failure RTE_MAX_ETHPORTS
> than 255.
>
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> ---
> test/test/test_event_eth_rx_adapter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/test/test_event_eth_rx_adapter.c b/test/test/test_event_eth_rx_adapter.c
> index ab55398..dee632b 100644
> --- a/test/test/test_event_eth_rx_adapter.c
> +++ b/test/test/test_event_eth_rx_adapter.c
> @@ -107,7 +107,7 @@ port_init(uint8_t port, struct rte_mempool *mp)
> static int
> init_ports(int num_ports)
> {
> - uint8_t portid;
> + uint16_t portid;
> int retval;
>
> default_params.mp = rte_pktmbuf_pool_create("packet_pool",
>
With above changes to commit message.
Acked-by: Nikhil Rao <nikhil.rao@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] test/eventdev: update the port id to 16 bit
2018-05-15 10:23 ` Rao, Nikhil
@ 2018-05-15 12:24 ` Varghese, Vipin
0 siblings, 0 replies; 5+ messages in thread
From: Varghese, Vipin @ 2018-05-15 12:24 UTC (permalink / raw)
To: Rao, Nikhil, dev, Jain, Deepak K
Thanks Nikhil, Have made changes and send a v2 for the same.
> -----Original Message-----
> From: Rao, Nikhil
> Sent: Tuesday, May 15, 2018 3:54 PM
> To: Varghese, Vipin <vipin.varghese@intel.com>; dev@dpdk.org; Jain, Deepak K
> <deepak.k.jain@intel.com>
> Cc: Rao, Nikhil <nikhil.rao@intel.com>
> Subject: Re: [PATCH] test/eventdev: update the port id to 16 bit
>
> On 5/15/2018 9:18 PM, Vipin Varghese wrote:
> > port id in test case is update to unsigned int 16 bit, to prvent
> > compilation faulure when RTE_ETH_MAX port is set more
> ^^^^^^^ ^^^^^^^ ^^^^^^^^^^^^^^^
> prevent failure RTE_MAX_ETHPORTS
> > than 255.
> >
> > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> > ---
> > test/test/test_event_eth_rx_adapter.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/test/test/test_event_eth_rx_adapter.c
> > b/test/test/test_event_eth_rx_adapter.c
> > index ab55398..dee632b 100644
> > --- a/test/test/test_event_eth_rx_adapter.c
> > +++ b/test/test/test_event_eth_rx_adapter.c
> > @@ -107,7 +107,7 @@ port_init(uint8_t port, struct rte_mempool *mp)
> > static int
> > init_ports(int num_ports)
> > {
> > - uint8_t portid;
> > + uint16_t portid;
> > int retval;
> >
> > default_params.mp = rte_pktmbuf_pool_create("packet_pool",
> >
>
> With above changes to commit message.
>
> Acked-by: Nikhil Rao <nikhil.rao@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH v2] test/eventdev: update the port id to 16 bit
2018-05-15 15:48 [dpdk-dev] [PATCH] test/eventdev: update the port id to 16 bit Vipin Varghese
2018-05-15 10:23 ` Rao, Nikhil
@ 2018-05-15 18:06 ` Vipin Varghese
2018-05-20 23:17 ` Thomas Monjalon
1 sibling, 1 reply; 5+ messages in thread
From: Vipin Varghese @ 2018-05-15 18:06 UTC (permalink / raw)
To: dev, deepak.k.jain, nikhil.rao; +Cc: Vipin Varghese
port id in test case is update to unsigned int 16 bit, to
prevent compilation failure when RTE_MAX_ETHPORTS port is
set more than 255.
Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
Acked-by: Nikhil Rao <nikhil.rao@intel.com>
---
Changes for V2:
spell check for commit message - Nikhil Rao
---
test/test/test_event_eth_rx_adapter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/test/test_event_eth_rx_adapter.c b/test/test/test_event_eth_rx_adapter.c
index ab55398..dee632b 100644
--- a/test/test/test_event_eth_rx_adapter.c
+++ b/test/test/test_event_eth_rx_adapter.c
@@ -107,7 +107,7 @@ port_init(uint8_t port, struct rte_mempool *mp)
static int
init_ports(int num_ports)
{
- uint8_t portid;
+ uint16_t portid;
int retval;
default_params.mp = rte_pktmbuf_pool_create("packet_pool",
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v2] test/eventdev: update the port id to 16 bit
2018-05-15 18:06 ` [dpdk-dev] [PATCH v2] " Vipin Varghese
@ 2018-05-20 23:17 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2018-05-20 23:17 UTC (permalink / raw)
To: Vipin Varghese; +Cc: dev, deepak.k.jain, nikhil.rao, stable
15/05/2018 20:06, Vipin Varghese:
> port id in test case is update to unsigned int 16 bit, to
> prevent compilation failure when RTE_MAX_ETHPORTS port is
> set more than 255.
>
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> Acked-by: Nikhil Rao <nikhil.rao@intel.com>
Fixes: fc8030eb8fe9 ("test/eventdev: add tests for eth Rx adapter APIs")
Cc: stable@dpdk.org
Applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-05-20 23:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-15 15:48 [dpdk-dev] [PATCH] test/eventdev: update the port id to 16 bit Vipin Varghese
2018-05-15 10:23 ` Rao, Nikhil
2018-05-15 12:24 ` Varghese, Vipin
2018-05-15 18:06 ` [dpdk-dev] [PATCH v2] " Vipin Varghese
2018-05-20 23:17 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).