From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BAC22A0521; Tue, 3 Nov 2020 11:04:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9B486C848; Tue, 3 Nov 2020 11:04:22 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 3ECACC832 for ; Tue, 3 Nov 2020 11:04:20 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id CDA425C00D3; Tue, 3 Nov 2020 05:04:19 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 03 Nov 2020 05:04:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= JPoFCkX/UUgKRWt0mSgY1C+JXmHLwbT1fqa64Mi66Sc=; b=p0XrYavXlE/k9IEZ ZT+5noYfU+fGm9zlfjGClK0DYmtP/ow3E5XEXPjTSXG04F6ZBBwZUqkz9+k+aCKH yiQGmPQzcnfhM6dUaKX4SvJNjUH8nucxdXJepOoUw3ML+XvcCjSM5xxJ7kGHGVZ7 Ybw4wLuSaVdfVof08IL6Zwj3j9dsEjB55LBkW7AEHfdDDPZ4xpAe0dQlHO9xHo4h wPajsWoL5/rGHN0GHbbUKvMyGaL1PT6BnSVe5V4n9pKU8nR5QsGZpKhLQNyjnjb7 vlqj+PXqhdh0pbGmeCzc3F9VI9Qj7rk6ZHPfvRO7Id+c7Hj7ZOBX16m3fkjp8xnH kJgDyQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=JPoFCkX/UUgKRWt0mSgY1C+JXmHLwbT1fqa64Mi66 Sc=; b=Hq4YTkMi+bCS1pTpQknmQbMpv4GEuJy9IwPl4GjTLmcJDc3Vvxl+Uj65F rIQY9bCgYntDZBUQrW971IHb6m1cVSlsJSfuDLPCynDVVlLWCqwXz3I2ZPuLCLN5 xKktjLo2Va73AN1KKWzm6olWsj8wMYytkqS5Dcw90zb8r8Z7B9xw4gUQPZyshjrz mdtLCUREkWJ+ZHNt2bF54IWHYjNrTYPYaLHkkXmWLsUQ3mIKGyeyriEJ8GHvASVN Sb14tI2xqZE+ADwpzpKuSLiiU4bFsE82p4RIshMTIiXz7uQ6hDcKI5yr0gYVWIaU OW2wyakwhAlEGfA7i3yn3S4rvwLdQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtfedgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrd dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6BB273280063; Tue, 3 Nov 2020 05:04:18 -0500 (EST) From: Thomas Monjalon To: David Marchand , Jerin Jacob Kollanukkaran , "McDaniel, Timothy" Cc: dev@dpdk.org Date: Tue, 03 Nov 2020 11:04:16 +0100 Message-ID: <2186962.mxLp5MSvJo@thomas> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [pull-request] next-eventdev 20.11 RC2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/11/2020 16:57, McDaniel, Timothy: > From: David Marchand > > On Mon, Nov 2, 2020 at 3:31 PM Jerin Jacob Kollanukkaran > > wrote: > > > > > > The following changes since commit > > 79d69c6dcf0debea38ac258d230e2f8c93e5ad12: > > > > > > mbuf: remove seqn field (2020-10-31 22:14:44 +0100) > > > > > > are available in the Git repository at: > > > > > > http://dpdk.org/git/next/dpdk-next-eventdev > > > > > > for you to fetch changes up to > > e06cd1ddfeac30b4926a52a69336b4f25a9cd209: > > > > > > eventdev: check input parameter for dump op (2020-11-02 19:16:51 +0530) > > > > > > ---------------------------------------------------------------- > > > David Marchand (1): > > > eventdev: check input parameter for dump op > > > > About this patch, could we squash some change in the dlb/dlb2 drivers? > > I guess Thomas could do it while pulling if nobody objects? > > > > > > diff --git a/drivers/event/dlb/dlb_xstats.c b/drivers/event/dlb/dlb_xstats.c > > index 89186d506e..5f4c590307 100644 > > --- a/drivers/event/dlb/dlb_xstats.c > > +++ b/drivers/event/dlb/dlb_xstats.c > > @@ -921,11 +921,6 @@ dlb_eventdev_dump(struct rte_eventdev *dev, FILE *f) > > struct dlb_hw_dev *handle; > > int i; > > > > - if (f == NULL) { > > - DLB_LOG_ERR("Invalid file pointer\n"); > > - return; > > - } > > - > > dlb = dlb_pmd_priv(dev); > > > > if (dlb == NULL) { > > diff --git a/drivers/event/dlb2/dlb2_xstats.c b/drivers/event/dlb2/dlb2_xstats.c > > index a274779fee..8c3c3cda94 100644 > > --- a/drivers/event/dlb2/dlb2_xstats.c > > +++ b/drivers/event/dlb2/dlb2_xstats.c > > @@ -972,11 +972,6 @@ dlb2_eventdev_dump(struct rte_eventdev *dev, FILE > > *f) > > struct dlb2_hw_dev *handle; > > int i; > > > > - if (f == NULL) { > > - DLB2_LOG_ERR("Invalid file pointer\n"); > > - return; > > - } > > - > > dlb2 = dlb2_pmd_priv(dev); > > > > if (dlb2 == NULL) { > > > > > > > > -- > > David Marchand > > I am fine with Thomas pulling these changes in. OK will do, after moving David's patch at first position.