From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2915A0503; Thu, 19 May 2022 13:26:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C791140222; Thu, 19 May 2022 13:26:57 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id D723140156 for ; Thu, 19 May 2022 13:26:56 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 933C85C0059; Thu, 19 May 2022 07:26:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 19 May 2022 07:26:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1652959614; x= 1653046014; bh=vs7KJtO+HmPQqEmU5rhvGPcNzAvnhR11DziPCq55y7A=; b=T BC1qYPRVICxFE/5j0C5MHI36ZAp/8iUqTQv7ArhZZlFUK/1/bxEVSRsugjgWFclC B1Q/RJz3yoogEUVVg2iDqhiKRRha5WYWFZJEd1zmBtJTRFY2gzKVEmHFjoTnoUQ5 YEtEm+eoRZhBVWwGVXWURicEbfPyDJlpZhybh7tgJnd8EaziT0LNDx+1f6FU+drl ECDOf1UE1g29Y8cPlTCsbm9c9mKKSkHbyChBySjC+hPW3agEateEkGQuGoWCckMq E7lJPUXpZDI8b0zzwmB53kNvBFQzGDj8a/8NJ4dhdskhFSBnL7ZzhUdMSKgDq6QI LWbnCsiNSvZsEJSMsyHNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1652959614; x= 1653046014; bh=vs7KJtO+HmPQqEmU5rhvGPcNzAvnhR11DziPCq55y7A=; b=R neYI4v+EYMLOm3cAMSYj2BER0t1lu6N5Z0GFGRoRvjZXWCdbfyhInVebz9Q5Ya3o SlURTfPMrUYN+ekL5vwOyQqXBObgDs3L6frQafpPw8EVIcVNYOBmWtx+9fqsc5Zo F4ZmIn4MpI8Fe4mnpgkFS7t2+wZ+w4r4mSccMWKQnHGlkWt1Sj//8WrBzx4rmlfB pAgZcy2TI2HZZdO23DRVFJ1f7VZ7BSMElJFci9VmzXEDsHoJqaKiQbU/E04sqE45 3ulc/MQ0wo0gIl80RFx+MOJf/EjBfq+0tKVVtLwxg24qjk8gi0aVP23JvPuAVdcv tIhkpJEpbAvgLKCFbUfpA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedriedugdeflecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdtuefhhedvkeelleevffdvlefhleehvdegtddvvdduueeivedt gfejvddugeefnecuffhomhgrihhnpeguphgukhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhn rdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 19 May 2022 07:26:51 -0400 (EDT) From: Thomas Monjalon To: Konstantin Ananyev , David Marchand Cc: dev@dpdk.org, "Min Hu (Connor)" , dev , Xiaoyun Li , Aman Singh , Yuying Zhang , Chas Williams , jerinj@marvell.com Subject: Re: [RFC PATCH 2/4] net/bonding: move testpmd commands Date: Thu, 19 May 2022 13:26:44 +0200 Message-ID: <2187851.KTMopqUuYO@thomas> In-Reply-To: References: <20220513075718.18674-1-david.marchand@redhat.com> <581f038e-a50a-175e-8336-c82f617954f5@yandex.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 19/05/2022 09:40, David Marchand: > On Thu, May 19, 2022 at 1:25 AM Konstantin Ananyev > wrote: > > 18/05/2022 18:24, David Marchand =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > > On Fri, May 13, 2022 at 12:10 PM Min Hu (Connor) = wrote: > > >> > > >> I think net/bonding offer 'API' for APP to use the bonding. > > >> and use the specific PMD as slave device. > > >> The software framwork is like: > > >> APP > > >> ethdev > > >> bonding PMD > > >> PMD > > >> hardware > > >> > > >> so, I think cmdlines for testpmd should not put in net/bonding.be The bonding API is specific to drivers/net/bonding/, so according to the techboard decision, the testpmd code should go in the driver directory. > > Actually, I feel the same. > > I do understand the intention, and I do realize it is just location, > > but still doesn't look right for me. > > can't we have a special sub-folder in testpmd instead? > > Something like app/testpmd/driver_specific/(ixgbe)|(i40e)|(bonding)... >=20 > That should not pose a problem, indeed. > And, on the plus side, it avoids putting some testpmd global variables > in meson (which I was not entirely happy with). I like the global variables approach. > But, on the other side, I have a concern about MAINTAINERS updates. >=20 > (almost) everything in app/test-pmd has been under the testpmd > maintainer responsibility. > Separating the driver specific code from testpmd is a way to clearly > shift this responsibility to the driver maintenance. I agree. > One advantage of moving the code to the driver directory is that there > is no MAINTAINERS update needed. Yes I think moving test code in the driver directory is smart. We already have this approach for some self tests run with app/test. And more important, the techboard has decided to move code in the driver or lib directory: https://mails.dpdk.org/archives/dev/2022-April/239191.html > If we keep those in app/test-pmd, it is still possible to mark the > driver-specific sources in MAINTAINERS, but such updates are often > missed. > I can probably add something in devtools/ to catch those updates in > the future... >=20 > I'll try for RFC v3.