DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ori Kam <orika@nvidia.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, andrew.rybchenko@oktetlabs.ru, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] Querying for rte_flow support?
Date: Wed, 29 Sep 2021 20:52:43 +0200	[thread overview]
Message-ID: <2188270.3AJhsh48eD@thomas> (raw)
In-Reply-To: <20210929104436.6fd88409@hermes.local>

29/09/2021 19:44, Stephen Hemminger:
> Have a problem with auto-detecting whether device driver supports rte_flow.
> 
> Ideally in application would like to be able adapt to handle devices that
> do rte_flow and those that do not.  If device does not support rte_flow,
> then configure with RSS across multiple cores; if device does support rte_flow
> then assign traffic to queue based on match (on MAC).
> 
> The problem is that there really is not a good API in DPDK for checking.
> Most device drivers will not give the correct return to rte_flow_validate
> unless the device is configured already, and some require device to be started.
> In order to configure, the application has to choose how many queues to use
> and that is the reason it wants to know if rte_flow will work!
> 
> The other alternative is looking at DPDK internal data structs to see
> if device supports flow operations. That is not good, and causes more
> issues in later releases.
> 
> Looks like rte_flow has a "chicken/egg problem" here.

I think we just need to fix drivers implementation of rte_flow_validate().
We must be able to validate a flow before starting the device.
Which drivers are refusing such check?
That's something we can check with some unit tests.



  reply	other threads:[~2021-09-29 18:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29 17:44 Stephen Hemminger
2021-09-29 18:52 ` Thomas Monjalon [this message]
2021-09-29 22:37   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2188270.3AJhsh48eD@thomas \
    --to=thomas@monjalon.net \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=orika@nvidia.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).