From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92AB141B7B; Wed, 11 Oct 2023 17:27:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45D5E40279; Wed, 11 Oct 2023 17:27:27 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 6A384400D7 for ; Wed, 11 Oct 2023 17:27:25 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 03A165C036F; Wed, 11 Oct 2023 11:27:25 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 11 Oct 2023 11:27:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1697038045; x=1697124445; bh=oatldV5eyPismd9i9IirXWTY3BFQwmk812I 9LPNpQVk=; b=KIXiJ5Q7dHAYmosVWPMSkH9i3LdHaXeHY1jxbIOFuhYOIhZujbC XE+tUjEiyrxq7Lk65x7hvbhP7S/m8sGU5XFhAfD9caSf01AguGwGKiYBaeNzXVkx NCTD9pXk4wHWBoobr5R2R/xBTZ+8zfb/q7U3UTfHT+ER03VatSSFIeVEc8s/RJvd d05YC57l+jKzu4M+dROs5lQ5XtDPrkhkfKTV7RnTno3pIAoAZClMb5s0iGa0uI7L OduCV7O7Jk3wDXGTz4N64d+KbhikJPlsMrj2RmP+x7b/8yUGaEt7El0sADxCRvgp wO1S9nl42fJiVh+XwLJXgxDzI6c70awGRuA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1697038045; x=1697124445; bh=oatldV5eyPismd9i9IirXWTY3BFQwmk812I 9LPNpQVk=; b=jOoFIJ7HW4BzlZQNNycvLuJBjc0fvc7WpUzoJVGmQ8RmhyRWTDy 0Rs1CyHl6/32srzUb6ixsyOLxLrOH1smDQwJwSzw0wCZL5x/g0NhQqto6FVXNjkE ZXVOGyC+6lAVEHXgvDRNHrbW9rZgnjksKwt6aE2kjck/EsMvyshjbGvGhawIUkki jL+6xhOSCpekmgugYjSl+ry57Y+WRl+7JKn7d+FQnJwSOtM5LVVQy/xraF6jvDZt xfjXdALOqu/bVUWPzl+3mWilukYhOaGLno5Gr2vgEN/5/yC6LoYJ/ZyJrR8JVdDS m/671BvRYBIVK4vLn4nMdTWRb7DepG8QSEQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrheekgdekiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 11 Oct 2023 11:27:23 -0400 (EDT) From: Thomas Monjalon To: Ric Li Cc: dev@dpdk.org, bruce.richardson@intel.com, david.marchand@redhat.com Subject: Re: [PATCH v2 1/2] build: fix list_dir_globs failure in MSYS2 Date: Wed, 11 Oct 2023 17:27:22 +0200 Message-ID: <2188661.NgBsaNRSFp@thomas> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 20/09/2023 16:18, Ric Li: > When running 'meson setup' on Windows with MSYS2, > "list-dir-globs.py * failed with status 1". We don't know why it is failing? What about other usages of list_dir_globs in drivers and lib? > Avoid using globbing to get components for app build > since they are already listed in the meson file. I don't understand the logic. > +disable_apps = ',' + get_option('disable_apps') > +disable_apps = run_command(list_dir_globs, disable_apps, check: true).stdout().split() This could fail. > + > +enable_apps = ',' + get_option('enable_apps') > +enable_apps = run_command(list_dir_globs, enable_apps, check: true).stdout().split() > +if enable_apps.length() == 0 > + enable_apps = apps > +endif If nothing is enabled, we enable all?