From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11E50A0032; Wed, 16 Mar 2022 20:34:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7412641143; Wed, 16 Mar 2022 20:34:25 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 2C424410EC; Wed, 16 Mar 2022 20:34:24 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id C49F45C0223; Wed, 16 Mar 2022 15:34:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 16 Mar 2022 15:34:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=DdOPbMNy9iDv9B S7kycxX/tMgLCfxN/TguoQcWBdbdE=; b=CtnXrrDzB6aLKKaGlHKn04POz2L4hF kRB4Z05vU8ZP7+ITEr8Hw7IWWjLYGOdSptvcG4AAmbvexTXxGpoe22OO8OZPQKXq AAL3vxZK6NDe4rYQW3HC+Ix8jf4l8DIA7pC+AcXTNPq18eWcsRQ3j9VW3MShv/qQ 3MlVdZFYhaU/fnYtEUNgOrrMV6jdLzBc8a5EeI6/XFOPhZ5Ib2fD/LryEdfUgb3J IGUNRqa9oPS3rJwAPOW4IIGlf9poo/8LlLZjIvbI4oVk5XJ4o0/itBmrSAcJYTP2 2QDOMsJwvqJdvxUZkv9FAPETc/4I6hp2fyR3wOn1hhuU6DxNYOHwJsXQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=DdOPbMNy9iDv9BS7kycxX/tMgLCfxN/TguoQcWBdb dE=; b=WRWF4BwGfUNGc2p13YICPd/qndOjqHiyP8U2PSwvKwPtlG5N2M7JNSPgS ZoCkvjTTmCAYFTZ0MPeoApcfHtRmSN2nTxeqFwbU3CZZGv5oADDq8nbdNlVlg7EU 0FUH3S+jgpCIObUy63y3XRohWguLIxs24/eUL4bmAp3BEenaITLGov82fHpdBaqE 6VWLfSipQPgXyO03euKg666aPz04nD15WG5OmUMThJKWVEjypAkKyTBUs+xAxvdh vQY+e9AD4pKanM/3PRTsA/trhFc2Kl6OZlH4PPnbKKmBS6i6VYBzfmM9BjVgyi/m jPLw/Pe6AO0SVLB1QTQmmpTxSlhFw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudefvddguddvfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 16 Mar 2022 15:34:22 -0400 (EDT) From: Thomas Monjalon To: "Huang, Wei" Cc: "Xu, Rosen" , "Gao, DaxueX" , stable@dpdk.org, "dev@dpdk.org" , "nipun.gupta@nxp.com" , "hemant.agrawal@nxp.com" , "Zhang, Tianfei" , "Zhang, Qi Z" , "Yigit, Ferruh" Subject: Re: [PATCH v1] raw/ifpga: initialize variable to avoid compile error Date: Wed, 16 Mar 2022 20:34:21 +0100 Message-ID: <21892462.EfDdHjke4D@thomas> In-Reply-To: <3116003.mvXUDI8C0e@thomas> References: <20220316072630.1916479-1-wei.huang@intel.com> <3116003.mvXUDI8C0e@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/03/2022 10:40, Thomas Monjalon: > 16/03/2022 10:27, Gao, DaxueX: > > From: Wei Huang > > > > > > Compile failed with cflag optimization=1 on Ubuntu20.04 with GCC10.3, it > > > reported vendor_id and dev_id may be used uninitialized in function > > > ifpga_rawdev_fill_info(). > > > Actually it's not the truth, the variables are initialized in function > > > ifpga_get_dev_vendor_id(). To avoid such compile error, the variables are > > > initialized when they are defined. > > > > > > Signed-off-by: Wei Huang > > > Acked-by: Tianfei Zhang > > > Acked-by: Rosen Xu > > > > Tested-by: Daxue Gao > > We need a "Fixes:" line to help backports, please. Added this: Fixes: 9c006c45d0c5 ("raw/ifpga: scan PCIe BDF device tree") Cc: stable@dpdk.org Applied in last minute.