* [dpdk-dev] [PATCH v2] app/testpmd: fix buffer leak in tm cmdline
@ 2018-07-05 5:45 Nithin Dabilpuram
2018-07-26 17:26 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Nithin Dabilpuram @ 2018-07-05 5:45 UTC (permalink / raw)
To: Wenzhuo Lu, Jingjing Wu, Bernard Iremonger; +Cc: dev, kkanas, Nithin Dabilpuram
Free the buffer allocated for shared_shaper_id array in
case of configuration without shared shapers.
Signed-off-by: Nithin Dabilpuram <nithin.dabilpuram@caviumnetworks.com>
Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
v2 changes:
- Modify subject to use proper keyword for test-pmd
- Change author email address
app/test-pmd/cmdline_tm.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c
index c904e44..7c1601f 100644
--- a/app/test-pmd/cmdline_tm.c
+++ b/app/test-pmd/cmdline_tm.c
@@ -1599,10 +1599,12 @@ static void cmd_add_port_tm_nonleaf_node_parsed(void *parsed_result,
np.shaper_profile_id = res->shaper_profile_id;
np.n_shared_shapers = n_shared_shapers;
- if (np.n_shared_shapers)
+ if (np.n_shared_shapers) {
np.shared_shaper_id = &shared_shaper_id[0];
- else
- np.shared_shaper_id = NULL;
+ } else {
+ free(shared_shaper_id);
+ shared_shaper_id = NULL;
+ }
np.nonleaf.n_sp_priorities = res->n_sp_priorities;
np.stats_mask = res->stats_mask;
@@ -1758,10 +1760,12 @@ static void cmd_add_port_tm_leaf_node_parsed(void *parsed_result,
np.n_shared_shapers = n_shared_shapers;
- if (np.n_shared_shapers)
+ if (np.n_shared_shapers) {
np.shared_shaper_id = &shared_shaper_id[0];
- else
- np.shared_shaper_id = NULL;
+ } else {
+ free(shared_shaper_id);
+ shared_shaper_id = NULL;
+ }
np.leaf.cman = res->cman_mode;
np.leaf.wred.wred_profile_id = res->wred_profile_id;
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH v2] app/testpmd: fix buffer leak in tm cmdline
2018-07-05 5:45 [dpdk-dev] [PATCH v2] app/testpmd: fix buffer leak in tm cmdline Nithin Dabilpuram
@ 2018-07-26 17:26 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2018-07-26 17:26 UTC (permalink / raw)
To: Nithin Dabilpuram
Cc: dev, Wenzhuo Lu, Jingjing Wu, Bernard Iremonger, kkanas,
cristian.dumitrescu
05/07/2018 07:45, Nithin Dabilpuram:
> Free the buffer allocated for shared_shaper_id array in
> case of configuration without shared shapers.
>
> Signed-off-by: Nithin Dabilpuram <nithin.dabilpuram@caviumnetworks.com>
> Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-26 17:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-05 5:45 [dpdk-dev] [PATCH v2] app/testpmd: fix buffer leak in tm cmdline Nithin Dabilpuram
2018-07-26 17:26 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).