DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, David Marchand <david.marchand@redhat.com>,
	Aaron Conole <aconole@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] devtools: add llx format specifier check
Date: Tue, 09 Feb 2021 17:38:53 +0100	[thread overview]
Message-ID: <2189598.20HeUBaClg@thomas> (raw)
In-Reply-To: <20210209152643.1832506-1-ferruh.yigit@intel.com>

09/02/2021 16:26, Ferruh Yigit:
> %llx tends to be wrong when used for fixed size, like uint64_t,
> variables, adding a warning to double check them.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> +	# check %llx usage
> +	awk -v FOLDERS='lib drivers app examples' \
> +		-v EXPRESSIONS='%ll*[xud]' \
> +		-v RET_ON_FAIL=1 \
> +		-v MESSAGE='Please check %llx usage which tends to be wrong most of the times' \

+1

It reminds me this old email:
http://mails.dpdk.org/archives/dev/2018-February/091483.html

The title mentions llx, but it should be %ll in general:
	devtools: check %ll format specifier



  reply	other threads:[~2021-02-09 16:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-09 15:26 Ferruh Yigit
2021-02-09 16:38 ` Thomas Monjalon [this message]
2021-05-19 19:24 ` [dpdk-dev] [PATCH v2] devtools: check %l format specifier Thomas Monjalon
2021-05-21 12:01   ` Ferruh Yigit
2021-05-21 13:09     ` Thomas Monjalon
2021-05-21 13:30 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2021-05-21 13:33   ` Ferruh Yigit
2021-05-21 13:36     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2189598.20HeUBaClg@thomas \
    --to=thomas@monjalon.net \
    --cc=aconole@redhat.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).