From: "Peng, ZhihongX" <zhihongx.peng@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "Ye, Xiaolong" <xiaolong.ye@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Wang, Liang-min" <liang-min.wang@intel.com>
Subject: Re: [dpdk-dev] [DPDK] net/ixgbe: fix status synchronization on BSD
Date: Sun, 26 Apr 2020 05:26:25 +0000 [thread overview]
Message-ID: <218C9AAF1879E445B4BC31BDA3D08502045E550E@CDSMSX102.ccr.corp.intel.com> (raw)
In-Reply-To: <20200326150150.6ac5829f@hermes.lan>
Sorry, because the mail filtering is wrong, I have not seen this mail, and the community canceled the patch. I resubmitted a pacth, only modified the format. Judging this flag, it feels a bit more complicated.
New patch: http://patches.dpdk.org/patch/68713/
-----Original Message-----
From: Stephen Hemminger [mailto:stephen@networkplumber.org]
Sent: Friday, March 27, 2020 6:02 AM
To: Peng, ZhihongX <zhihongx.peng@intel.com>
Cc: Ye, Xiaolong <xiaolong.ye@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com>; dev@dpdk.org; Wang, Liang-min <liang-min.wang@intel.com>
Subject: Re: [dpdk-dev] [DPDK] net/ixgbe: fix status synchronization on BSD
On Tue, 24 Mar 2020 23:31:11 -0400
zhihongx.peng@intel.com wrote:
> +/*BSD has no interrupt mechanism, so force NIC status
> +synchronization.*/ #ifdef RTE_EXEC_ENV_FREEBSD
> + wait = 1;
> +#endif
> +
Please format comments correctly.
Is there a better way to detect interrupt mechanism with a function?
#ifdef's make for hard to maintain code.
next prev parent reply other threads:[~2020-04-26 5:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 3:31 zhihongx.peng
2020-03-26 22:01 ` Stephen Hemminger
2020-04-26 5:26 ` Peng, ZhihongX [this message]
2020-03-25 7:32 zhihongx.peng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=218C9AAF1879E445B4BC31BDA3D08502045E550E@CDSMSX102.ccr.corp.intel.com \
--to=zhihongx.peng@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=liang-min.wang@intel.com \
--cc=stephen@networkplumber.org \
--cc=wenzhuo.lu@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).