From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1E62A00C5; Sun, 26 Apr 2020 07:26:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 89FFC2B93; Sun, 26 Apr 2020 07:26:32 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 86891100C for ; Sun, 26 Apr 2020 07:26:31 +0200 (CEST) IronPort-SDR: /INqud3EL5pZZQ6vE2E+Xnze2L8krP3LGuZfWLerMV6vlOT5IxTydkP2oklOkwJqzBecVgVxy/ pUr1c3JXOsIg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2020 22:26:30 -0700 IronPort-SDR: nsy3sP4NUmJLZ9aDnyhDX21r3USYq1oEMNgcgehUrEvta/We8R+dn1c/FrOBrFpahTpAdVgaon IbMXnuHWhkPA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,318,1583222400"; d="scan'208";a="260311220" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga006.jf.intel.com with ESMTP; 25 Apr 2020 22:26:29 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 25 Apr 2020 22:26:29 -0700 Received: from cdsmsx104.ccr.corp.intel.com (172.17.3.38) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 25 Apr 2020 22:26:28 -0700 Received: from cdsmsx102.ccr.corp.intel.com ([169.254.2.104]) by CDSMSX104.ccr.corp.intel.com ([169.254.4.172]) with mapi id 14.03.0439.000; Sun, 26 Apr 2020 13:26:25 +0800 From: "Peng, ZhihongX" To: Stephen Hemminger CC: "Ye, Xiaolong" , "Lu, Wenzhuo" , "Ananyev, Konstantin" , "dev@dpdk.org" , "Wang, Liang-min" Thread-Topic: [dpdk-dev] [DPDK] net/ixgbe: fix status synchronization on BSD Thread-Index: AQHWAlay/AmA9k9ezkG3BBUTAOirLqha6YMAgDAm43A= Date: Sun, 26 Apr 2020 05:26:25 +0000 Message-ID: <218C9AAF1879E445B4BC31BDA3D08502045E550E@CDSMSX102.ccr.corp.intel.com> References: <20200325033111.9650-1-zhihongx.peng@intel.com> <20200326150150.6ac5829f@hermes.lan> In-Reply-To: <20200326150150.6ac5829f@hermes.lan> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.17.6.105] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [DPDK] net/ixgbe: fix status synchronization on BSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Sorry, because the mail filtering is wrong, I have not seen this mail, and = the community canceled the patch. I resubmitted a pacth, only modified the = format. Judging this flag, it feels a bit more complicated. New patch: http://patches.dpdk.org/patch/68713/ -----Original Message----- From: Stephen Hemminger [mailto:stephen@networkplumber.org]=20 Sent: Friday, March 27, 2020 6:02 AM To: Peng, ZhihongX Cc: Ye, Xiaolong ; Lu, Wenzhuo ; Ananyev, Konstantin ; dev@dpdk.org; Wang, = Liang-min Subject: Re: [dpdk-dev] [DPDK] net/ixgbe: fix status synchronization on BSD On Tue, 24 Mar 2020 23:31:11 -0400 zhihongx.peng@intel.com wrote: > +/*BSD has no interrupt mechanism, so force NIC status=20 > +synchronization.*/ #ifdef RTE_EXEC_ENV_FREEBSD > + wait =3D 1; > +#endif > + Please format comments correctly. Is there a better way to detect interrupt mechanism with a function? #ifdef's make for hard to maintain code.