From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F01F8A00C5; Wed, 28 Sep 2022 14:08:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A669B41143; Wed, 28 Sep 2022 14:08:20 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id D5D664113D for ; Wed, 28 Sep 2022 14:08:18 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 77F2D5C0036; Wed, 28 Sep 2022 08:08:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 28 Sep 2022 08:08:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1664366897; x= 1664453297; bh=ECVuj07bUvNTp0+LN31AT+WAxaJektcCl8kRe1xUu/4=; b=c xn+6X7e35XkhdQ680wVBn8CSJwTUQ1mC5UkAHqAC2DXzWJUau/pIPfUcGljaYN/N xO9BV5GFsgO8l3Aa2FBYAFuu4t5v2rWjc0bZKNOVEimT0koZ9YwuiXag0c4VoZDv XtlC+vRGdwMi0leAiYtSfr51Ev3J5dgkffROBS5wyLnTNf/G3qm286QW/x2qlgcM HuQiHgLlud1cwhmYPRl6uO3zANXvqC6UN5x8fq/XNQ40XqAdl27wfP9e03ZzIZE5 tndnxRxiYWv4jBv/MzssmHBPzgrsJO6OWUOyOgcEcvboVsMcOv+ho10l01WbJyO1 kCit31tV/S6nhr0Zgc7Xg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1664366897; x= 1664453297; bh=ECVuj07bUvNTp0+LN31AT+WAxaJektcCl8kRe1xUu/4=; b=t NoCiZ7SQsdoQcmzjjcQe9ooQrdZdC9BH/CI/mv6F01EUvwRewS0WwBQTIXIeiI+k VZKacULuKBIhL+Qc6kAtBQCw6o+IV3Aw5x3H23tmSrWK5KG30xD3mzfzdUXmaGBl G70XfnQFiYRYIqDO1OaIQkWnN4VpqvJOFKU50r65L0h/E/9gEJQLO54kWaJF8m3h hQ204LXurfoqIkXs74ITc9iEw4GaCVQuvRncPKUjdMJVvZNMTAV1wzBbkbI3H3tJ qCmjk33146OP0GFFPc+9nIVZxgPidGxQgsEpkvXBt/hLwU6pz8wTdsQ4mXP2Y2Gn flfAH1JF3MjM5UK5LQkCw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegkedggeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtvdefgfdtleeiuddvvdelkefgfeelkeetvedthffhjeevteeg tdfhudfgueejieenucffohhmrghinhepvghthhguvghvrdguvggrlhenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhj rghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 28 Sep 2022 08:08:15 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson , Olivier Matz , Jerin Jacob Cc: Jerin Jacob , skori@marvell.com, Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org, david.marchand@redhat.com, orika@nvidia.com Subject: Re: [PATCH v2 1/1] ethdev: support congestion management Date: Wed, 28 Sep 2022 14:08:14 +0200 Message-ID: <21900891.hxa6pUQ8Du@thomas> In-Reply-To: References: <20220713130340.2886839-1-jerinj@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 28/09/2022 13:14, Jerin Jacob: > On Tue, Sep 27, 2022 at 8:39 PM Bruce Richardson > wrote: > > > > On Tue, Sep 27, 2022 at 04:36:18PM +0200, Thomas Monjalon wrote: > > > > > ++ > > > > > > I feel EAL is not the right place for CMAN definitions. > > > > > > After a discussion with Jerin, I understand we could use the same > > > definitions in other API classes, not only ethdev. However I think this > > > .h file should be better hosted in lib/ethdev/ with its own namespace > > > rte_cman. Then other libs could include this rte_cman.h without having a > > > strong dependency on ethdev. > > > > > > Deal? > > > > > Would rte_net also be an option? Alternatively, is this related to the work > > Looks like the net is a good option. Since it is just a header file > any place would be OK. > > + @Olivier Matz > > Any objections to keeping rte_cman.h to lib/net? lib/net/ is supposed to be standardized packet headers definitions.