DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Tyler Retzlaff <roretzla@linux.microsoft.com>,
	stable@dpdk.org
Subject: Re: [PATCH v1 1/1] malloc/mp: fix wait condition handling
Date: Tue, 23 Jul 2024 15:42:23 +0200	[thread overview]
Message-ID: <2190224.irdbgypaU6@thomas> (raw)
In-Reply-To: <a6eb861b5689deaa75493d7399da962c9a4e37d2.1720784477.git.anatoly.burakov@intel.com>

12/07/2024 13:41, Anatoly Burakov:
> From coverity's point of view, it is theoretically possible to have an
> infinite wait on a wait condition because while we do check for timeout,
> we do not check for whether the event we are waiting for has already
> occurred by the time we get to the first cond_wait call (in this case,
> it's state of memory request list entry's state being set to COMPLETE).
> 
> This can't really happen as the only time a wait condition is triggered
> is when we are receiving a memory event (so the entry we are waiting on
> cannot change before wait condition is triggered because it's protected
> by a mutex), so either we receive an event and modify entry state, or we
> exit wait on a timeout and do not care about request state. However, it's
> better to keep coverity happy.
> 
> Coverity issue: 425709
> Fixes: 07dcbfe0101f ("malloc: support multiprocess memory hotplug")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied, thanks.



      reply	other threads:[~2024-07-23 13:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-12 11:41 Anatoly Burakov
2024-07-23 13:42 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2190224.irdbgypaU6@thomas \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=roretzla@linux.microsoft.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).