* [dpdk-dev] [PATCH] app/test: fix a segfault when lpm_perf_autotest is run more than 1 time
@ 2016-11-01 10:47 Nikita Kozlov
2016-11-01 11:20 ` [dpdk-dev] [PATCH v2] " Nikita Kozlov
2016-11-01 11:20 ` [dpdk-dev] [PATCH] " Bruce Richardson
0 siblings, 2 replies; 6+ messages in thread
From: Nikita Kozlov @ 2016-11-01 10:47 UTC (permalink / raw)
To: dev
num_route_entries need to be reseted.
---
app/test/test_lpm_perf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c
index 608e17a..e7e1281 100644
--- a/app/test/test_lpm_perf.c
+++ b/app/test/test_lpm_perf.c
@@ -301,6 +301,7 @@ static void generate_large_route_rule_table(void)
uint32_t ip_class;
uint8_t depth;
+ num_route_entries = 0;
memset(large_route_table, 0, sizeof(large_route_table));
for (ip_class = IP_CLASS_A; ip_class <= IP_CLASS_C; ip_class++) {
--
2.9.2
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH v2] app/test: fix a segfault when lpm_perf_autotest is run more than 1 time
2016-11-01 10:47 [dpdk-dev] [PATCH] app/test: fix a segfault when lpm_perf_autotest is run more than 1 time Nikita Kozlov
@ 2016-11-01 11:20 ` Nikita Kozlov
2016-11-01 11:55 ` [dpdk-dev] [PATCH v3] " Nikita Kozlov
2016-11-01 11:20 ` [dpdk-dev] [PATCH] " Bruce Richardson
1 sibling, 1 reply; 6+ messages in thread
From: Nikita Kozlov @ 2016-11-01 11:20 UTC (permalink / raw)
To: dev
num_route_entries need to be reseted.
V2 : resubmitting the patch with a signed-off
Signed-off-by: Nikita Kozlov <nikita@elyzion.net>
---
app/test/test_lpm_perf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c
index 608e17a..e7e1281 100644
--- a/app/test/test_lpm_perf.c
+++ b/app/test/test_lpm_perf.c
@@ -301,6 +301,7 @@ static void generate_large_route_rule_table(void)
uint32_t ip_class;
uint8_t depth;
+ num_route_entries = 0;
memset(large_route_table, 0, sizeof(large_route_table));
for (ip_class = IP_CLASS_A; ip_class <= IP_CLASS_C; ip_class++) {
--
2.9.2
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH v3] app/test: fix a segfault when lpm_perf_autotest is run more than 1 time
2016-11-01 11:20 ` [dpdk-dev] [PATCH v2] " Nikita Kozlov
@ 2016-11-01 11:55 ` Nikita Kozlov
2016-11-03 3:28 ` Dai, Wei
0 siblings, 1 reply; 6+ messages in thread
From: Nikita Kozlov @ 2016-11-01 11:55 UTC (permalink / raw)
To: dev
num_route_entries need to be reseted.
Fixes: 17d60f5b5eea ("app/test: remove large IPv4 LPM data file")
Signed-off-by: Nikita Kozlov <nikita@elyzion.net>
---
app/test/test_lpm_perf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c
index 608e17a..e7e1281 100644
--- a/app/test/test_lpm_perf.c
+++ b/app/test/test_lpm_perf.c
@@ -301,6 +301,7 @@ static void generate_large_route_rule_table(void)
uint32_t ip_class;
uint8_t depth;
+ num_route_entries = 0;
memset(large_route_table, 0, sizeof(large_route_table));
for (ip_class = IP_CLASS_A; ip_class <= IP_CLASS_C; ip_class++) {
--
2.9.2
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v3] app/test: fix a segfault when lpm_perf_autotest is run more than 1 time
2016-11-01 11:55 ` [dpdk-dev] [PATCH v3] " Nikita Kozlov
@ 2016-11-03 3:28 ` Dai, Wei
2016-11-06 22:55 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Dai, Wei @ 2016-11-03 3:28 UTC (permalink / raw)
To: Nikita Kozlov, dev, Richardson, Bruce, Dai, Wei
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Nikita Kozlov
> Sent: Tuesday, November 1, 2016 7:56 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v3] app/test: fix a segfault when lpm_perf_autotest
> is run more than 1 time
>
> num_route_entries need to be reseted.
>
> Fixes: 17d60f5b5eea ("app/test: remove large IPv4 LPM data file")
>
> Signed-off-by: Nikita Kozlov <nikita@elyzion.net>
Tested-by: Bruce Richardson <bruce.richardson@intel.com>
Tested-by: Wei Dai <wei.dai@intel.com>
Acked-by: Wei Dai <wei.dai@intel.com>
> ---
> app/test/test_lpm_perf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c index
> 608e17a..e7e1281 100644
> --- a/app/test/test_lpm_perf.c
> +++ b/app/test/test_lpm_perf.c
> @@ -301,6 +301,7 @@ static void generate_large_route_rule_table(void)
> uint32_t ip_class;
> uint8_t depth;
>
> + num_route_entries = 0;
> memset(large_route_table, 0, sizeof(large_route_table));
>
> for (ip_class = IP_CLASS_A; ip_class <= IP_CLASS_C; ip_class++) {
> --
> 2.9.2
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v3] app/test: fix a segfault when lpm_perf_autotest is run more than 1 time
2016-11-03 3:28 ` Dai, Wei
@ 2016-11-06 22:55 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2016-11-06 22:55 UTC (permalink / raw)
To: Nikita Kozlov; +Cc: dev, Dai, Wei, Richardson, Bruce
> > num_route_entries need to be reseted.
> >
> > Fixes: 17d60f5b5eea ("app/test: remove large IPv4 LPM data file")
> >
> > Signed-off-by: Nikita Kozlov <nikita@elyzion.net>
> Tested-by: Bruce Richardson <bruce.richardson@intel.com>
> Tested-by: Wei Dai <wei.dai@intel.com>
> Acked-by: Wei Dai <wei.dai@intel.com>
Appplied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] app/test: fix a segfault when lpm_perf_autotest is run more than 1 time
2016-11-01 10:47 [dpdk-dev] [PATCH] app/test: fix a segfault when lpm_perf_autotest is run more than 1 time Nikita Kozlov
2016-11-01 11:20 ` [dpdk-dev] [PATCH v2] " Nikita Kozlov
@ 2016-11-01 11:20 ` Bruce Richardson
1 sibling, 0 replies; 6+ messages in thread
From: Bruce Richardson @ 2016-11-01 11:20 UTC (permalink / raw)
To: Nikita Kozlov; +Cc: dev
On Tue, Nov 01, 2016 at 11:47:42AM +0100, Nikita Kozlov wrote:
> num_route_entries need to be reseted.
> ---
> app/test/test_lpm_perf.c | 1 +
> 1 file changed, 1 insertion(+)
>
You forgot your signoff on the patch, but I confirm it does indeed fix
the issue. Also, as fixes line is needed to identify the commit that
introduced the bug.
Tested-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-11-06 22:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-01 10:47 [dpdk-dev] [PATCH] app/test: fix a segfault when lpm_perf_autotest is run more than 1 time Nikita Kozlov
2016-11-01 11:20 ` [dpdk-dev] [PATCH v2] " Nikita Kozlov
2016-11-01 11:55 ` [dpdk-dev] [PATCH v3] " Nikita Kozlov
2016-11-03 3:28 ` Dai, Wei
2016-11-06 22:55 ` Thomas Monjalon
2016-11-01 11:20 ` [dpdk-dev] [PATCH] " Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).