From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C27C2A0524; Fri, 8 Jan 2021 11:24:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 414E6140E6D; Fri, 8 Jan 2021 11:24:07 +0100 (CET) Received: from wnew1-smtp.messagingengine.com (wnew1-smtp.messagingengine.com [64.147.123.26]) by mails.dpdk.org (Postfix) with ESMTP id D0697140E69 for ; Fri, 8 Jan 2021 11:24:05 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.west.internal (Postfix) with ESMTP id 363C91B44; Fri, 8 Jan 2021 05:24:02 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 08 Jan 2021 05:24:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= JvEE4j2SAvlHORlZ4nVlEuUaflLwKN6luahPcXRZngY=; b=WFACOKUQuJ/QFdDy 3LKi4LGu5g+bvmawAd8sz+QhySIFwmmKf70INkcIsMsfWsgVixkmLDFniB/ukHq6 HqGEQc+3Yi9p6280PHScZYaFrwvgLh23ZCX3mbyI/pwk4guceTKEHLiJ7hDAwAKh fIQCdzbF4PH24cjSd/JA0xkkd9QanfrsuvyuP2xPsLaDHxTuf/K9pYAp2mq1O4X3 ZQw5z+iIPuuOuRLfC+SUvvnqa+SnnTRJaDWZhBqZiZvuFRIP9WFoRmR0+TY68gYd PR5oPYmqsAuWufjIFbh/7OvZ5VUyJyU6e0kEbYq4/aQbWPp6BKaAiT5ipLNQHxfG sd81RA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=JvEE4j2SAvlHORlZ4nVlEuUaflLwKN6luahPcXRZn gY=; b=UQmnT3gxTjWOz6NadtZhTKRZaQUro7DrMxbS15gPhBYuAx73xmJu36+sz /+tiJ65SCWnbdfOF1uOuYPGebCONRxMEtDDz4jOOdylg4CLK5i7BnGjsd3TR1WcT zFGtnndCCjrM3njsLXyhU45GlCFxFv1tYCXG7hNXMLYoXoJLtHBMBvbvHhnO94JY GBwDbJh99/LS8W/t77UjH37CPJLzh9Y6dvaqniiDUBV26u/CMvWdPBgZj+GOMyZg ucrofI5L/JD7diZ5WGG+gsejf7+J98bc7u0dPkOAo50x6j9/NrHmMsNpr5vhdd2F tFPazb13IPHKqIrr2F/ss33eMiqYA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdeggedgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepgeejfffhhfeghfetveffgeffteelveekhffghfefgedvleeuveet fffgudelvefhnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepjeejrddufe egrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 91D7D24005E; Fri, 8 Jan 2021 05:23:59 -0500 (EST) From: Thomas Monjalon To: "Guo, Jia" , "Zhang, Qi Z" , Ferruh Yigit Cc: "Wu, Jingjing" , "Yang, Qiming" , "Wang, Haiyue" , "dev@dpdk.org" , "andrew.rybchenko@oktetlabs.ru" , "orika@nvidia.com" , "getelson@nvidia.com" , Dodji Seketeli , ray.kinsella@intel.com Date: Fri, 08 Jan 2021 11:23:58 +0100 Message-ID: <2191627.gY80Bp0Rq6@thomas> In-Reply-To: References: <20201216085854.7842-1-jia.guo@intel.com> <27289607.Vi9ZVq1Shk@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/01/2021 10:22, Ferruh Yigit: > On 1/7/2021 1:33 PM, Thomas Monjalon wrote: > > 07/01/2021 13:47, Zhang, Qi Z: > >> From: Thomas Monjalon > >>> 07/01/2021 10:32, Guo, Jia: > >>>> From: Thomas Monjalon > >>>>> Sorry, it is a nack. > >>>>> BTW, it is probably breaking the ABI because of RTE_TUNNEL_TYPE_MAX. > >> > >> Yes that may break the ABI but fortunately the checking-abi-compatibility tool shows negative :) , thanks Ferruh' s guide. > >> https://github.com/ferruhy/dpdk/actions/runs/468859673 > > > > That's very strange. An enum value is changed. > > Why it is not flagged by libabigail? > > As long as the enum values not sent to the application and kept within the > library, changing their values shouldn't be problem. But RTE_TUNNEL_TYPE_MAX is part of lib/librte_ethdev/rte_ethdev.h so it is exposed to the application. I think it is a case of ABI breakage.