From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f169.google.com (mail-wr0-f169.google.com [209.85.128.169]) by dpdk.org (Postfix) with ESMTP id 6248E282 for ; Tue, 11 Apr 2017 09:50:57 +0200 (CEST) Received: by mail-wr0-f169.google.com with SMTP id c55so89547496wrc.3 for ; Tue, 11 Apr 2017 00:50:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=1wk+UCbhu+0zvrFCMHlEq8EnzKRTjnBAxS2qxRk9sXk=; b=b9/4omIhymZmJfionk7iEe//Wk8cgEguT1SICGEobCkU9V0KS2JfLz2GGNi4UijOBT CUbiov0h97ZWXMpHXXt1QVoEYjJJM9uL5/wxshNTCHSlI4GaDuJ5ZkP1VGO4ETA3bui0 DX9nZCXcDnypEQxZ5bAFHAgp61CItTMr1ZkLIWdT6MqfILTLWv6jGXEqmLAEFyaFCI9F Z9hK241rhbjJ3SNPD9FjlObsaYAYYgECUtvy5w5vHO4ykteeF4oFDPQP5+AsoDQInG6g qkX61WIR57V1p8BVOE0jaNTGIBqA5GaDThR6g8UZvo/AmrREnvnuMTlT3qorIJIgKrF8 Wk7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=1wk+UCbhu+0zvrFCMHlEq8EnzKRTjnBAxS2qxRk9sXk=; b=ZBl5ikKZFVd+021e9Y+cEe4M+RV7NqY4NcyrigUVSXx2B3+UuDjm4OyTH55MA1xiPb 1vs6Z5FvHUXK3q6LEXiWXvkDBEU5yyAIaj/QYQgvE6nopei16182hK0CjfqYRXAXF4iz ZuY/KJjJK0FjReVySfgsGOO1r9Z1sYFynGdSWzQYth4DXgJkPpSoAByBm+uU3i2vko5E QMRZuB9Lsp7OFDfpHQStdzf7gaIZ/bABuZlBYYRORvdyYMDol/mMHCUCoSH3wExlkjsW pwqgqbKe0ZTv4MbusD2sk5+Z6/6QEiWKpY2YvllxOgnZVEyc0hpfOyeTc6O/jKyAz1Zj euZQ== X-Gm-Message-State: AN3rC/4OPV6vDhfkm1o2umrKCEg7ZSt9x6L1po3mkEfJcsAmPl4WzCtaWVr10+BKAt7U9dVW X-Received: by 10.223.133.133 with SMTP id 5mr13752237wrt.83.1491897057142; Tue, 11 Apr 2017 00:50:57 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id 134sm1363345wmj.6.2017.04.11.00.50.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Apr 2017 00:50:56 -0700 (PDT) From: Thomas Monjalon To: Hemant Agrawal Cc: Olivier MATZ , dev@dpdk.org, shreyansh.jain@nxp.com, ferruh.yigit@intel.com Date: Tue, 11 Apr 2017 09:50:55 +0200 Message-ID: <21940728.tivBTtkBCF@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <9977cf0c-e1cf-b235-e199-c5242daa75c2@nxp.com> References: <1489754838-1455-2-git-send-email-hemant.agrawal@nxp.com> <20170410215847.704092d2@neon> <9977cf0c-e1cf-b235-e199-c5242daa75c2@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] mempool/dpaa2: add DPAA2 hardware offloaded mempool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Apr 2017 07:50:57 -0000 2017-04-11 11:28, Hemant Agrawal: > On 4/11/2017 1:28 AM, Olivier MATZ wrote: > > Hemant Agrawal wrote: > >> --- a/drivers/bus/Makefile > >> +++ b/drivers/bus/Makefile > >> @@ -33,6 +33,10 @@ include $(RTE_SDK)/mk/rte.vars.mk > >> > >> core-libs := librte_eal librte_mbuf librte_mempool librte_ring librte_ether > >> > >> +ifeq ($(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL),y) > >> +CONFIG_RTE_LIBRTE_FSLMC_BUS = $(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL) > >> +endif > >> + > >> DIRS-$(CONFIG_RTE_LIBRTE_FSLMC_BUS) += fslmc > >> DEPDIRS-fslmc = ${core-libs} > >> > > > > What's the purpose of this? > > Not sure we are allowed to modify the configs in the Makefiles. > > DPAA2_MEMPOOL will not work without the DPAA2 mempool hw instance > detected on FSLMC_BUS. > So, it is required that if you are enabling DPAA2_MEMPOOL, FSLMC_BUS is > to be enabled. > > Currently the config structure do not provide such dependency definitions. > > This was done based on the suggestions on the initial patches from > Ferruh and Jerin. Please do not do that. We do not change the configuration in the back of the user. This kind of dependency should be managed in the configuration step which do not exist yet. You can use $(error) to stop the compilation instead.