From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38437A00E6 for ; Thu, 8 Aug 2019 09:17:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5DD3F2082; Thu, 8 Aug 2019 09:17:26 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 755E2DE3; Thu, 8 Aug 2019 09:17:24 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1C27120CB3; Thu, 8 Aug 2019 03:17:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 08 Aug 2019 03:17:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=BG6Ae/j6yfAnNtxlrH+ddA4+a/4JNbID8Ut6UN6mKds=; b=DxJtmNL4p1cT JcvgY2yRpZU9qgjwVyHbSOlpo8pP7WyMYaiYNfwI/LkDZs7a9TnlENl1ED3am+LE yZiw861P4m2jT50ktitc7w4RjbQmRiSA3dJDoAI57+YcnkjycqrmoPYobHze3Vsb MDVv6PYZmUZp9ueIrgpdOdmhJp2DFsI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=BG6Ae/j6yfAnNtxlrH+ddA4+a/4JNbID8Ut6UN6mK ds=; b=EJSvN/6hbkdzCUMpwOWWm/Ds3Hkr6lVy4FL/rm3O6bLxxHZX7CSHId5+p rRjATbb1kTMbpScStm43PHKaxmDxnshTpT3ueJtQdVjPY1gWHWPvV3U7YCSJDgL9 j0bUPqGzz9yhQe7CnWuDRVbqNle6v3pIaWlEnAv/OeuEADor/x8Ppzv30KM2jcDb Ft04bptlpF06X3X0iccvawhUftS3v0Cu6L64AfA3KdmH98EKn3WPBKQhU/Bxq+2l 3dy+h4x/hnve+kC8jfBJr8OJVaUdDobG+tyfQzw2pKceLsVjRFr532PAzKtgSzRW TcSOSUv+EG2jNgMjYx5wRJvsGRgmQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddruddugedgleduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeelfedriedrudegledruddugeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhm rghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114]) by mail.messagingengine.com (Postfix) with ESMTPA id CC0BC80064; Thu, 8 Aug 2019 03:17:21 -0400 (EDT) From: Thomas Monjalon To: Andrius Sirvys , Kevin Laatz Cc: dev@dpdk.org, stable@dpdk.org, john.mcnamara@intel.com Date: Thu, 08 Aug 2019 09:17:19 +0200 Message-ID: <2194097.CDRCBNjSrz@xps> In-Reply-To: <20190807130458.16754-1-andrius.sirvys@intel.com> References: <20190807130458.16754-1-andrius.sirvys@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] usertools: dpdk-telemetry-client.py run into looping status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/08/2019 15:04, Andrius Sirvys: > The ast.literal_eval() was used incorrectly and wouldn't properly > retrieve the user option. Was causing the options to keep being listed > in a loop. Removed and replaced with raw_input() being cast to an int. > Works as expected now. You mean you added "ast.literal_eval()" without testing it? Kevin, that's not the first time I ask, who is testing this telemetry stuff? I have the bad feeling this is a toy, and you send random untested patches for it. How I can know this patch is seriously tested enough before merging it at the last minute in 19.08? > Fixes: 53f293c9a783 ("usertools: replace unsafe input function") > Cc: andrius.sirvys@intel.com > > Signed-off-by: Andrius Sirvys > --- > v2: Removed unnecessary comments Please keep all versions in the same email thread by using --in-reply-to > try: > - raw_input # Python 2 > + raw_input # Python 2 > except NameError: > - raw_input = input # Python 3 > + raw_input = input # Python 3 Why changing this indentation?