From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D9C7A04DD; Mon, 16 Nov 2020 21:24:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 296D4F94; Mon, 16 Nov 2020 21:24:30 +0100 (CET) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id 44B66F3E for ; Mon, 16 Nov 2020 21:24:27 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 99FB2580388; Mon, 16 Nov 2020 15:24:25 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 16 Nov 2020 15:24:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= bjGByPMOaRdm6DmQgRJJAP+lCouENogynVWnII6qTws=; b=vzwlyHbvc05GTZ+9 wtFld4c053nMtzjfyu9S4htl2pq3jI8YLRC9wsoE8bFTY5e8omNfOc79bm45DBd+ X2SN0VWHcmAVXtb57bTpkRAWsBWVRxyK0/6xacej+VnsJgVCRAWoXjEHsVKqn6OF AW5y27NnzU+vJC+BeaROHMDplELIqM2c2wbJ34m73rE1jYMD1EmFx4Ry+KPJRBkN ndcXOplqdcU/eD36G36F1RYHCyIKbzrL3JQSI7tNIHnl745VzrXfjEEuT3YomGnB iJK+tissTIyo2W7uShyQXHtLobN9a1OgtEZts0kRxeySr7BP7G7RSmj9d4MJbjNB zrkKHA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=bjGByPMOaRdm6DmQgRJJAP+lCouENogynVWnII6qT ws=; b=MfpEK/Uuv0aw6uFfFPDJ6NjE2UEJKeEPS3FpICKGC1z8zoMpEZ1FW2554 /4gtTqQMSdz2m0AUjpLoGA9cV/Bc8W4BEmnlkHfXpwMBLPWme0ea7BjC55Q3VvdE 9d3rW2+OHnxsWRz4xNyh6fOYcvBQ+/UX2FC12nvqOGgaY89Ja0jYXvaDWXI1yBrj iScXui8yJwgTSj7Hkns8etWoS5ppnuatZhpr4HMSOQnxjAW51+jMR68O0wh6TXB9 9kPJDIKC9earlADHTQzL/O9aQEsHT+RqYgbkdhZcA88Aubp2OqU2f8hx2yC0fYLp PmFa0Ci85jgd/uLrrMiMMsB/rXAkQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudefuddgudefjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeeh teffvdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefge drvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9DB483064AAE; Mon, 16 Nov 2020 15:24:23 -0500 (EST) From: Thomas Monjalon To: Qi Zhang , Ferruh Yigit Cc: Wenzhuo Lu , Beilei Xing , Bernard Iremonger , dev@dpdk.org, Steve Yang , Andrew Rybchenko , Konstantin Ananyev , Olivier Matz , Lance Richardson , David Marchand Date: Mon, 16 Nov 2020 21:24:21 +0100 Message-ID: <2195073.9XJvc8EHFU@thomas> In-Reply-To: <93c1f68a-75aa-c7f4-b245-7bd477006a07@intel.com> References: <20201105180942.2938152-1-ferruh.yigit@intel.com> <20201113114400.3356527-1-ferruh.yigit@intel.com> <93c1f68a-75aa-c7f4-b245-7bd477006a07@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix MTU after device configure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/11/2020 19:50, Ferruh Yigit: > On 11/13/2020 11:44 AM, Ferruh Yigit wrote: > > In 'rte_eth_dev_configure()', if 'DEV_RX_OFFLOAD_JUMBO_FRAME' is not set > > the max frame size is limited to 'RTE_ETHER_MAX_LEN' (1518). > > This is mistake because for the PMDs that has frame size bigger than > > "RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN" (18 bytes), the MTU becomes > > less than 1500, causing a valid frame with 1500 bytes payload to be > > dropped. > > > > Since 'rte_eth_dev_set_mtu()' works as expected, it is called after > > 'rte_eth_dev_configure()' to fix the MTU. > > It may look redundant to set MTU after 'rte_eth_dev_configure()', both > > with default values, but it is not, the resulting MTU config can be > > different in the device based on frame overhead of the PMD. > > > > And instead of setting the MTU to default value, it is first get via > > 'rte_eth_dev_get_mtu()' and set again, this is to cover cases MTU > > changed from testpmd command line. > > > > 'rte_eth_dev_set_mtu()', '-ENOTSUP' error is ignored to prevent > > irrelevant warning messages for the virtual PMDs. > > > > Signed-off-by: Ferruh Yigit > > Reviewed-by: Qi Zhang > > --- > > @David highlighted that 'scatter' tests are failing in the lab with this commit, > https://lab.dpdk.org/results/dashboard/patchsets/14492/ To be more precise, this error showed up in the CI even before the patch was merged: https://patches.dpdk.org/patch/84132/ We should be more careful with the CI results before merging. > With above commit only 'mtu' is taken into account, so in testpmd both > "--max-pkt-len=N" parameter and "port config all max-pkt-len #" command are no > more working as expected. This seems the reason of the failure. > > Technically it is possible to fix dts testcase by adding following commands: > port stop all > port config mtu 0 9000 > port start all > > But, there may be other side affects from "max-pkt-len" is not working in > testpmd as expected. Reverting this one too can be safest option. Next fix will be the right one ;)