DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Michael Savisko <michaelsav@nvidia.com>
Cc: dev@dpdk.org, asafp@nvidia.com, orika@nvidia.com,
	Ferruh Yigit <ferruh.yigit@xilinx.com>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [PATCH 1/3] ethdev: add send to kernel action
Date: Mon, 12 Sep 2022 15:14:45 +0200	[thread overview]
Message-ID: <2195181.iZASKD2KPV@thomas> (raw)
In-Reply-To: <20220912125908.922188-1-michaelsav@nvidia.com>

Hi,

Please don't split ethdev, testpmd and doc in different patches.
They are all very related and may come together in a single patch.

12/09/2022 14:59, Michael Savisko:
> In some cases application may receive a packet that should have been
> received by the kernel. In this case application uses KNI or other means
> to transfer the packet to the kernel.

You should mention bifurcated driver capability:
in isolated mode, with mlx5, we can receive directly in the kernel.
Are we able to do the same with Linux TC rules?

> This commit introduces rte flow action that the application may use
> to route the packet to the kernel while still in the HW.

Should we understand it is the opposite of isolated mode?

[...]
> +	/*
> +	 * Send traffic to kernel.
> +	 */

You should make explicit that the traffic is directed to the kernel,
without going to userspace at all.
A reference to the isolated mode would be worthwhile as well.

> +	RTE_FLOW_ACTION_TYPE_SEND_TO_KERNEL,




      parent reply	other threads:[~2022-09-12 13:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-12 12:59 Michael Savisko
2022-09-12 12:59 ` [PATCH 2/3] app/testpmd: add new action kernel Michael Savisko
2022-09-12 12:59 ` [PATCH 3/3] doc: update testpmd application guide Michael Savisko
2022-09-12 13:14 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2195181.iZASKD2KPV@thomas \
    --to=thomas@monjalon.net \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=asafp@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@xilinx.com \
    --cc=michaelsav@nvidia.com \
    --cc=orika@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).