From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 0771A7E75 for ; Wed, 12 Nov 2014 11:22:56 +0100 (CET) Received: by mail-wg0-f45.google.com with SMTP id x12so13938839wgg.18 for ; Wed, 12 Nov 2014 02:32:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=ZlXbTgsmiUNKKiXy+KIT5yfF9BE5VXeRfNMW7n6WnR4=; b=e6UFkxqiswANYypI3qbqZI3O807O+g9/i8jMrJx7P8w0BdiM3WWUMb/3DK0A1qHc62 icssiC4ApxYAA8EKym/nSY6177EWmexf6pvGYDzJcIs/Efq8YdQBVYoiYFbuKYOWaQsb md4XYk59kQSueBrMG0dPPbFdWZcdEkcBmz18KbHzLlxG9ETXIgS4AGdY2yGPRTcYuxUA SfeXnNnCX+nFA4BrLd95b5ohSs7/aTAeWd1SSunBTJkX8HAiIkIr67+C7qEffJ+Qqq3D N8YSgJZ4KtOlepld+XNOHXvDYwhne+nhP+u8eRdGEpCMFh2glWr7KKMT4U+RRjkmEi/K oQ7Q== X-Gm-Message-State: ALoCoQn7afjmq4zB9OUvDe7Byj61z7PaGaKtBRVhyGv9EyGeWN1YY+q1voqlcry0RSxsd397o33F X-Received: by 10.180.104.232 with SMTP id gh8mr4170529wib.78.1415788369751; Wed, 12 Nov 2014 02:32:49 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id ci9sm21060545wid.24.2014.11.12.02.32.48 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Nov 2014 02:32:48 -0800 (PST) From: Thomas Monjalon To: "Liang, Cunming" Date: Wed, 12 Nov 2014 11:32:31 +0100 Message-ID: <2198498.ADxB2GqUVu@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: References: <1414372809-14044-1-git-send-email-cunming.liang@intel.com> <2823765.s7EKI2PXYZ@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v7 2/7] ixgbe:clean scattered_rx configure in dev_stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Nov 2014 10:22:56 -0000 2014-11-12 10:29, Liang, Cunming: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2014-11-12 08:21, Liang, Cunming: > > > For em, igb and i40e, we haven't provide so much rx/tx pair for switching. > > > > Sorry, I don't understand. Which pair are you telling about? > > em, igb and i40e have scattered Rx functions. > > Maybe pair is not accurate, I means the different rx/tx register function, like: > Ixgbe_recv_bulk_alloc/ixgbe_recv_(scattered_)pkts_vec/ixgbe_recv_scattered_pkts > ixgbe_xmit_pkts_simple/Ixgbe_xmit_pkts_vec/ixgbe_xmit_pkts OK that's what I understood. However, you should check the scatter/non-scatter Rx functions of other drivers. I think they need the same fix. Thanks -- Thomas