From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60766A2EFC for ; Tue, 15 Oct 2019 12:12:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E60BD1E8E2; Tue, 15 Oct 2019 12:12:14 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id EC4DB1E8BD for ; Tue, 15 Oct 2019 12:12:13 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 5145428007C; Tue, 15 Oct 2019 10:12:12 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 15 Oct 2019 11:12:06 +0100 To: Ori Kam , Thomas Monjalon , Ferruh Yigit CC: , , References: <1569479349-36962-1-git-send-email-orika@mellanox.com> <1571130263-120863-1-git-send-email-orika@mellanox.com> <1571130263-120863-2-git-send-email-orika@mellanox.com> From: Andrew Rybchenko Message-ID: <21993a52-3033-bf42-2041-0c50519ee5d1@solarflare.com> Date: Tue, 15 Oct 2019 13:12:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <1571130263-120863-2-git-send-email-orika@mellanox.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24978.003 X-TM-AS-Result: No-18.342600-8.000000-10 X-TMASE-MatchedRID: IeZYkn8zfFrmLzc6AOD8DTIjK23O9D33t3aeg7g/usAw9y3BDa9b9zlC Rr8Hb3qiXbLhfvpbIkhJgn8XPCcYRnT3K3VineCfUyxW4vmvLt27xmCZDXrutSBwR3y4lKPEUgA DWWOEbmN2wcINfceTjnDlPghqPnfyYlldA0POS1L/V0SDC1Do0IHLFWR93TgkNukyDIB+Hbrtfr H67fQFiEVaniEl2F6Z8tzR1ItIreWvPOitCEFhh8Vbb3pjW5MnF2jIWUnlRQzVm/zFztl3S8nT2 CRMJUbb0+z6fSKfo4R3LvdswyE0xrT0jVEXWzBwgmAd4Attpn9zwDh4RTtcHGAMM0WKD4aswRJD FANVUnU9NMmIcmum8X6lRhfNJXCj2C/g6fpNpuMqsMfMfrOZRTLKL6f4fTnRHWtVZN0asTgL5vw VVFrN+9q3iNNfacs6jifUaolAbk9it0K5B6nCjI6MisxJraxHyJnnD1Feeo5BL//DKiVczlQgfv oorQE+8AQZaqCuA2Jz/CYH11P2AGi8YU2giSiP2fov7TwhL8k6En2bnefhoMOtrkhuZC9WF3ZbJ F5bl5t1lky3Q+O6TSM4FX4RqI4VvdmVNDo5L3ySvRb8EMdYRQD4keG7QhHm4w7R7P4I0tIUHOLN IgkDPOWo9uvj96aasc1/N5KMATM9jVuxXDELzXYZxYoZm58Fm2CUy/KcAJ6ZfDRE1uqSgp2PyNq +B8xIrxMUprgZXRpSPK6dt1SokMQeIOzgVmNsamOGWbsSIFdDyJQKgOPwxMLmw90hW1s7e6iwif O6FIy1tYziQyBRUMR2DpJkWV4003wBrnThasKeAiCmPx4NwLTrdaH1ZWqC1B0Hk1Q1KyLgfCfWl nNb/1cppCzPq+1UkGUtrowrXLg= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--18.342600-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24978.003 X-MDID: 1571134333-jdNkVZqopu51 Subject: Re: [dpdk-dev] [PATCH v3 01/14] ethdev: add support for hairpin queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ori, On 10/15/19 12:04 PM, Ori Kam wrote: > This commit introduce hairpin queue type. > > The hairpin queue in build from Rx queue binded to Tx queue. > It is used to offload traffic coming from the wire and redirect it back > to the wire. > > There are 3 new functions: > - rte_eth_dev_hairpin_capability_get > - rte_eth_rx_hairpin_queue_setup > - rte_eth_tx_hairpin_queue_setup > > In order to use the queue, there is a need to create rte_flow > with queue / RSS action that targets one or more of the Rx queues. > > Signed-off-by: Ori Kam > > --- > V3: > - update according to ML comments. > > V2: > - update according to ML comments. > > --- > lib/librte_ethdev/rte_ethdev.c | 260 ++++++++++++++++++++++++++++++- > lib/librte_ethdev/rte_ethdev.h | 143 ++++++++++++++++- > lib/librte_ethdev/rte_ethdev_core.h | 27 +++- > lib/librte_ethdev/rte_ethdev_version.map | 5 + > 4 files changed, 422 insertions(+), 13 deletions(-) > > diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c > index af82360..22a97de 100644 > --- a/lib/librte_ethdev/rte_ethdev.c > +++ b/lib/librte_ethdev/rte_ethdev.c > @@ -904,10 +904,19 @@ struct rte_eth_dev * > > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_start, -ENOTSUP); > > - if (dev->data->rx_queue_state[rx_queue_id] != RTE_ETH_QUEUE_STATE_STOPPED) { > - RTE_ETHDEV_LOG(INFO, > - "Queue %"PRIu16" of device with port_id=%"PRIu16" already started\n", > + if (dev->data->rx_queue_state[rx_queue_id] == > + RTE_ETH_QUEUE_STATE_HAIRPIN) { > + RTE_ETHDEV_LOG(INFO, "Queue %"PRIu16" of device with " > + "port_id=%"PRIu16" is hairpin queue\n", > rx_queue_id, port_id); > + return -EINVAL; > + } > + > + if (dev->data->rx_queue_state[rx_queue_id] == > + RTE_ETH_QUEUE_STATE_STARTED) { > + RTE_ETHDEV_LOG(INFO, "Queue %"PRIu16" of device with " > + "port_id=%"PRIu16" already started\n", rx_queue_id, > + port_id); > return 0; > } > You should not touch existing code here. Yes, line is longer than 80 symbols, but fixing codding style is a separate thing. Also format string should not be split into many lines since it makes it hard to use grep to find it in sources (i.e. when you see it in longs and would like to find corresponding line in sources). [snip] > @@ -1758,6 +1791,92 @@ struct rte_eth_dev * > } > > int > +rte_eth_rx_hairpin_queue_setup(uint16_t port_id, uint16_t rx_queue_id, > + uint16_t nb_rx_desc, > + const struct rte_eth_hairpin_conf *conf) > +{ > + int ret; > + struct rte_eth_dev *dev; > + struct rte_eth_hairpin_cap cap; > + struct rte_eth_dev_info dev_info; > + void **rxq; > + int i; > + int count = 0; > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL); > + > + dev = &rte_eth_devices[port_id]; > + if (rx_queue_id >= dev->data->nb_rx_queues) { > + RTE_ETHDEV_LOG(ERR, "Invalid RX queue_id=%u\n", rx_queue_id); > + return -EINVAL; > + } > + ret = rte_eth_dev_hairpin_capability_get(port_id, &cap); > + if (ret != 0) > + return ret; > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get, -ENOTSUP); There is not necessity to check the pointer here, since it is checked inside rte_eth_dev_info_get() and error is returned. > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_hairpin_queue_setup, > + -ENOTSUP); > + /* Use default specified by driver, if nb_rx_desc is zero */ > + if (nb_rx_desc == 0) > + nb_rx_desc = cap.max_nb_desc; > + if (nb_rx_desc > cap.max_nb_desc) { > + RTE_ETHDEV_LOG(ERR, > + "Invalid value for nb_rx_desc(=%hu), should be: " > + "<= %hu", nb_rx_desc, cap.max_nb_desc); > + return -EINVAL; > + } > + ret = rte_eth_dev_info_get(port_id, &dev_info); > + if (ret != 0) > + return ret; > + if (dev->data->dev_started && > + !(dev_info.dev_capa & > + RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP)) > + return -EBUSY; > + if (dev->data->dev_started && > + (dev->data->rx_queue_state[rx_queue_id] != > + RTE_ETH_QUEUE_STATE_STOPPED)) > + return -EBUSY; As I understand it does not allow to change hairpin queue setup by calling setup once agian. > + if (conf->peer_n > cap.max_rx_2_tx) { > + RTE_ETHDEV_LOG(ERR, > + "Invalid value for number of peers(=%hu), " > + "should be: <= %hu", conf->peer_n, > + cap.max_rx_2_tx); > + return -EINVAL; > + } > + if (conf->peer_n == 0) { > + RTE_ETHDEV_LOG(ERR, > + "Invalid value for number of peers(=%hu), " > + "should be: > 0", conf->peer_n); > + return -EINVAL; > + } > + if (cap.max_n_queues != UINT16_MAX) { > + for (i = 0; i < dev->data->nb_rx_queues; i++) { > + if (dev->data->rx_queue_state[i] == > + RTE_ETH_QUEUE_STATE_HAIRPIN) > + count++; > + } > + if (count > cap.max_n_queues) { > + RTE_ETHDEV_LOG(ERR, > + "To many Rx hairpin queues %d", count); > + return -EINVAL; > + } > + } > + rxq = dev->data->rx_queues; > + if (rxq[rx_queue_id] != NULL) { > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_release, > + -ENOTSUP); > + (*dev->dev_ops->rx_queue_release)(rxq[rx_queue_id]); > + rxq[rx_queue_id] = NULL; > + } > + ret = (*dev->dev_ops->rx_hairpin_queue_setup)(dev, rx_queue_id, > + nb_rx_desc, conf); > + if (ret == 0) > + dev->data->rx_queue_state[rx_queue_id] = > + RTE_ETH_QUEUE_STATE_HAIRPIN; > + return eth_err(port_id, ret); > +} > + > +int > rte_eth_tx_queue_setup(uint16_t port_id, uint16_t tx_queue_id, > uint16_t nb_tx_desc, unsigned int socket_id, > const struct rte_eth_txconf *tx_conf) > @@ -1851,9 +1970,92 @@ struct rte_eth_dev * > __func__); > return -EINVAL; > } > + ret = (*dev->dev_ops->tx_queue_setup)(dev, tx_queue_id, nb_tx_desc, > + socket_id, &local_conf); > + return eth_err(port_id, ret); > +} Unrelated change > > - return eth_err(port_id, (*dev->dev_ops->tx_queue_setup)(dev, > - tx_queue_id, nb_tx_desc, socket_id, &local_conf)); > +int > +rte_eth_tx_hairpin_queue_setup(uint16_t port_id, uint16_t tx_queue_id, > + uint16_t nb_tx_desc, > + const struct rte_eth_hairpin_conf *conf) > +{ > + struct rte_eth_dev *dev; > + struct rte_eth_hairpin_cap cap; > + struct rte_eth_dev_info dev_info; > + void **txq; > + int i; > + int count = 0; > + int ret; > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL); > + dev = &rte_eth_devices[port_id]; > + if (tx_queue_id >= dev->data->nb_tx_queues) { > + RTE_ETHDEV_LOG(ERR, "Invalid TX queue_id=%u\n", tx_queue_id); > + return -EINVAL; > + } > + ret = rte_eth_dev_hairpin_capability_get(port_id, &cap); > + if (ret != 0) > + return ret; > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get, -ENOTSUP); There is not necessity to check the pointer here, since it is checked inside rte_eth_dev_info_get() and error is returned. > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_hairpin_queue_setup, > + -ENOTSUP); > + rte_eth_dev_info_get(port_id, &dev_info); Please, check return status. > + /* Use default specified by driver, if nb_tx_desc is zero */ > + if (nb_tx_desc == 0) > + nb_tx_desc = cap.max_nb_desc; > + if (nb_tx_desc > cap.max_nb_desc) { > + RTE_ETHDEV_LOG(ERR, > + "Invalid value for nb_tx_desc(=%hu), should be: " > + "<= %hu", nb_tx_desc, cap.max_nb_desc); > + return -EINVAL; > + } > + if (conf->peer_n > cap.max_tx_2_rx) { > + RTE_ETHDEV_LOG(ERR, > + "Invalid value for number of peers(=%hu), " > + "should be: <= %hu", conf->peer_n, > + cap.max_tx_2_rx); > + return -EINVAL; > + } > + if (conf->peer_n == 0) { > + RTE_ETHDEV_LOG(ERR, > + "Invalid value for number of peers(=%hu), " > + "should be: > 0", conf->peer_n); > + return -EINVAL; > + } > + if (cap.max_n_queues != UINT16_MAX) { > + for (i = 0; i < dev->data->nb_tx_queues; i++) { > + if (dev->data->tx_queue_state[i] == > + RTE_ETH_QUEUE_STATE_HAIRPIN) > + count++; > + } > + if (count > cap.max_n_queues) { > + RTE_ETHDEV_LOG(ERR, > + "To many Rx hairpin queues %d", count); > + return -EINVAL; > + } > + } I don't understand why order of checks differ above and here. > + if (dev->data->dev_started && > + !(dev_info.dev_capa & > + RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP)) > + return -EBUSY; > + if (dev->data->dev_started && > + (dev->data->tx_queue_state[tx_queue_id] != > + RTE_ETH_QUEUE_STATE_STOPPED)) > + return -EBUSY; As I understand it does not allow to change hairpin queue setup by calling setup once agian. > + txq = dev->data->tx_queues; > + if (txq[tx_queue_id] != NULL) { > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_queue_release, > + -ENOTSUP); > + (*dev->dev_ops->tx_queue_release)(txq[tx_queue_id]); > + txq[tx_queue_id] = NULL; > + } > + ret = (*dev->dev_ops->tx_hairpin_queue_setup) > + (dev, tx_queue_id, nb_tx_desc, conf); > + if (ret == 0) > + dev->data->tx_queue_state[tx_queue_id] = > + RTE_ETH_QUEUE_STATE_HAIRPIN; > + return eth_err(port_id, ret); > } > > void [snip] > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index d937fb4..51843c1 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h [snip] > @@ -1277,6 +1317,7 @@ struct rte_eth_dcb_info { > */ > #define RTE_ETH_QUEUE_STATE_STOPPED 0 > #define RTE_ETH_QUEUE_STATE_STARTED 1 > +#define RTE_ETH_QUEUE_STATE_HAIRPIN 2 See my notes below. Also, may be out of scope of the review, but I'd move these defines out of public header to rte_ethdev_driver.h in a separate patch. > #define RTE_ETH_ALL RTE_MAX_ETHPORTS > > @@ -1771,6 +1812,36 @@ int rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id, > struct rte_mempool *mb_pool); > > /** > + * @warning > + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice > + * > + * Allocate and set up a hairpin receive queue for an Ethernet device. > + * > + * The function set up the selected queue to be used in hairpin. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param rx_queue_id > + * The index of the receive queue to set up. > + * The value must be in the range [0, nb_rx_queue - 1] previously supplied > + * to rte_eth_dev_configure(). > + * @param nb_rx_desc > + * The number of receive descriptors to allocate for the receive ring. > + * 0 means the PMD will use default value. > + * @param conf > + * The pointer to the hairpin configuration. There is empty line between parameters and return description below, but it is missing here. It should be the same in both places and I'd prefer to have empty line to make it easier to read. > + * @return > + * - (0) if successful. > + * - (-ENOTSUP) if hardware doesn't support. > + * - (-EINVAL) if bad parameter. > + * - (-ENOMEM) if unable to allocate the resources. > + */ > +__rte_experimental > +int rte_eth_rx_hairpin_queue_setup > + (uint16_t port_id, uint16_t rx_queue_id, uint16_t nb_rx_desc, > + const struct rte_eth_hairpin_conf *conf); > + > +/** > * Allocate and set up a transmit queue for an Ethernet device. > * > * @param port_id > @@ -1823,6 +1894,35 @@ int rte_eth_tx_queue_setup(uint16_t port_id, uint16_t tx_queue_id, > const struct rte_eth_txconf *tx_conf); > > /** > + * @warning > + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice > + * > + * Allocate and set up a transmit hairpin queue for an Ethernet device. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param tx_queue_id > + * The index of the transmit queue to set up. > + * The value must be in the range [0, nb_tx_queue - 1] previously supplied > + * to rte_eth_dev_configure(). > + * @param nb_tx_desc > + * The number of transmit descriptors to allocate for the transmit ring. > + * 0 to set default PMD value. > + * @param conf > + * The hairpin configuration. > + * > + * @return > + * - (0) if successful. > + * - (-ENOTSUP) if hardware doesn't support. > + * - (-EINVAL) if bad parameter. > + * - (-ENOMEM) if unable to allocate the resources. > + */ > +__rte_experimental > +int rte_eth_tx_hairpin_queue_setup > + (uint16_t port_id, uint16_t tx_queue_id, uint16_t nb_tx_desc, > + const struct rte_eth_hairpin_conf *conf); > + > +/** > * Return the NUMA socket to which an Ethernet device is connected > * > * @param port_id [snip] > diff --git a/lib/librte_ethdev/rte_ethdev_core.h b/lib/librte_ethdev/rte_ethdev_core.h > index dcb5ae6..ef46e71 100644 > --- a/lib/librte_ethdev/rte_ethdev_core.h > +++ b/lib/librte_ethdev/rte_ethdev_core.h > @@ -250,6 +250,12 @@ typedef int (*eth_rx_queue_setup_t)(struct rte_eth_dev *dev, > struct rte_mempool *mb_pool); > /**< @internal Set up a receive queue of an Ethernet device. */ > > +typedef int (*eth_rx_hairpin_queue_setup_t) > + (struct rte_eth_dev *dev, uint16_t rx_queue_id, > + uint16_t nb_rx_desc, > + const struct rte_eth_hairpin_conf *conf); > +/**< @internal Set up a receive hairpin queue of an Ethernet device. */ > + Please, write down full description similar to eth_promiscuous_enable_t before the typedef. Don't forgot about return values listing. > typedef int (*eth_tx_queue_setup_t)(struct rte_eth_dev *dev, > uint16_t tx_queue_id, > uint16_t nb_tx_desc, > @@ -257,6 +263,12 @@ typedef int (*eth_tx_queue_setup_t)(struct rte_eth_dev *dev, > const struct rte_eth_txconf *tx_conf); > /**< @internal Setup a transmit queue of an Ethernet device. */ > > +typedef int (*eth_tx_hairpin_queue_setup_t) > + (struct rte_eth_dev *dev, uint16_t tx_queue_id, > + uint16_t nb_tx_desc, > + const struct rte_eth_hairpin_conf *hairpin_conf); > +/**< @internal Setup a transmit hairpin queue of an Ethernet device. */ > + Please, write down full description similar to eth_promiscuous_enable_t before the typedef. Don't forgot about return values listing. > typedef int (*eth_rx_enable_intr_t)(struct rte_eth_dev *dev, > uint16_t rx_queue_id); > /**< @internal Enable interrupt of a receive queue of an Ethernet device. */ > @@ -505,6 +517,10 @@ typedef int (*eth_pool_ops_supported_t)(struct rte_eth_dev *dev, > const char *pool); > /**< @internal Test if a port supports specific mempool ops */ > > +typedef int (*eth_hairpin_cap_get_t)(struct rte_eth_dev *dev, > + struct rte_eth_hairpin_cap *cap); > +/**< @internal get the hairpin capabilities. */ > + Please, write down full description similar to eth_promiscuous_enable_t before the typedef. Don't forgot about return values listing. If you reorder functions as suggested below, hairpin queue setup typedefs should be defiend here. > /** > * @internal A structure containing the functions exported by an Ethernet driver. > */ > @@ -557,6 +573,8 @@ struct eth_dev_ops { > eth_queue_start_t tx_queue_start;/**< Start TX for a queue. */ > eth_queue_stop_t tx_queue_stop; /**< Stop TX for a queue. */ > eth_rx_queue_setup_t rx_queue_setup;/**< Set up device RX queue. */ > + eth_rx_hairpin_queue_setup_t rx_hairpin_queue_setup; > + /**< Set up device RX hairpin queue. */ > eth_queue_release_t rx_queue_release; /**< Release RX queue. */ > eth_rx_queue_count_t rx_queue_count; > /**< Get the number of used RX descriptors. */ > @@ -568,6 +586,8 @@ struct eth_dev_ops { > eth_rx_enable_intr_t rx_queue_intr_enable; /**< Enable Rx queue interrupt. */ > eth_rx_disable_intr_t rx_queue_intr_disable; /**< Disable Rx queue interrupt. */ > eth_tx_queue_setup_t tx_queue_setup;/**< Set up device TX queue. */ > + eth_tx_hairpin_queue_setup_t tx_hairpin_queue_setup; > + /**< Set up device TX hairpin queue. */ > eth_queue_release_t tx_queue_release; /**< Release TX queue. */ > eth_tx_done_cleanup_t tx_done_cleanup;/**< Free tx ring mbufs */ > > @@ -639,6 +659,9 @@ struct eth_dev_ops { > > eth_pool_ops_supported_t pool_ops_supported; > /**< Test if a port supports specific mempool ops */ > + > + eth_hairpin_cap_get_t hairpin_cap_get; > + /**< Returns the hairpin capabilities. */ May I suggest to put hairpin queue setup functions here. It will group hairpin related functions here. > }; > > /** > @@ -746,9 +769,9 @@ struct rte_eth_dev_data { > dev_started : 1, /**< Device state: STARTED(1) / STOPPED(0). */ > lro : 1; /**< RX LRO is ON(1) / OFF(0) */ > uint8_t rx_queue_state[RTE_MAX_QUEUES_PER_PORT]; > - /**< Queues state: STARTED(1) / STOPPED(0). */ > + /**< Queues state: HAIRPIN(2) / STARTED(1) / STOPPED(0). */ > uint8_t tx_queue_state[RTE_MAX_QUEUES_PER_PORT]; > - /**< Queues state: STARTED(1) / STOPPED(0). */ > + /**< Queues state: HAIRPIN(2) STARTED(1) / STOPPED(0). */ / is missing above after HAIRPIN(2). In fact there is no point to duplicate values in parenthesis, but it is out of scope of the review. I'm not 100% happy that it makes impossible to mark hairpin queues as started/stopped. It is not that important right now, but may be it is better to use state as bit field. Bit 0 - stopped/started, bit 1 - regular/hairpin. Anyway, it is internal interface. [snip]