From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 2D8E22BD5 for ; Tue, 30 Aug 2016 12:30:25 +0200 (CEST) Received: by mail-wm0-f49.google.com with SMTP id i5so27974357wmg.0 for ; Tue, 30 Aug 2016 03:30:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=D7UvNaSTnxA6+B/2WkbQrP+W7XWmKtKFqFBn6iNghOQ=; b=ogJb0dicfCP4z+AuCtPTAYE2q6Saj9diwg+X9vYBzVmH39oOuUSsO8yGQXeQo0oLud 9CBZ/JOLXu2SRsu3FPz/TKh3Q1HUccHjm9HAAMtkxbEEPV83z7HWHuuM6cvbv1MU0JdO ltKpI9uWpj3fmaeU5ls77DFy4CrjFPuomYPh/Ozy644ke+PFy/+S2SDTXWHKNhhWtDsk o0kexsbd6+1x42Ia8yHLYsgZzm6+ERki+GSIcxYECBZQX8Kk9gglyh0LUzLap+ansuEM wK1H0qQJLn+qTGpUjhM5rcDPwJ+e6Af1pYiUmu3s4uA118vso6NK4aTWuO1dU4u5dqP+ 0DuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=D7UvNaSTnxA6+B/2WkbQrP+W7XWmKtKFqFBn6iNghOQ=; b=R8rST6g2nfMrr7w88SEUWbcFnYo+/rfgDXXml4FjGMpMFuc+so6uTt84Tby8oj18Gy KRfg48jGGrB6l3mwfNMNd35uNaBkp21Sp/Sn6aNXCUOXypRB0bB73TJa5D9zim95dMIp XWMQ+aCklmeVZe73ZC48/X016HFEMXBf5hVdYxskmODfvAtT0Xxi3Zp7dkDCUakMRf6C rg/+0YfAtge9zqG+pks0Hr6gv1jNDKr42v/RLFruWUCkyigmv1/sbzJ1dkyA4zkF9uHy slj4AH7qLZUbC0qcwgZlXVlWLmC0IDXs94dF+vmqf29Ckbi5h27OMSRfqcSXPZqWcjeS CrGQ== X-Gm-Message-State: AE9vXwNZTyIpYmFG+6jSi2hWEF+Y24CvGF+xS2gMcvL9cs8jVEuIjaTYRswfxbphBGYln6W1 X-Received: by 10.28.109.197 with SMTP id b66mr15795423wmi.68.1472553024891; Tue, 30 Aug 2016 03:30:24 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id wc3sm38813308wjc.47.2016.08.30.03.30.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Aug 2016 03:30:23 -0700 (PDT) From: Thomas Monjalon To: Shreyansh Jain Cc: Ferruh Yigit , dev@dpdk.org, viktorin@rehivetech.com, david.marchand@6wind.com, hemant.agrawal@nxp.com Date: Tue, 30 Aug 2016 12:30:22 +0200 Message-ID: <2199965.TtOmKzW9OO@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <57C46637.3060707@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 01/25] eal: define macro container_of X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Aug 2016 10:30:25 -0000 2016-08-30 09:57, Shreyansh Jain: > On Monday 29 August 2016 10:13 PM, Ferruh Yigit wrote: > > This gives compilation error for mlx5, because the libraries mlx depends > > defines same macro: > > ..../rte_common.h:338:9: error: 'container_of' macro redefined > > /usr/include/infiniband/verbs.h:77:9: note: previous definition is here > > I thought testing with scripts/test-build.sh and default configuration > would compile all drivers - I was wrong. I will retest the patches and > release again. > > Is there a better way to test that no driver breaks? Any particular > parameters I should use for test-build.sh? Yes I suggest to create a file ~/.config/dpdk/devel.config to adapt the configuration to your system. Once you have installed the required dependencies, you can make this kind of configuration: mlxdep=$root/mlx/mofed-3.3-1.0.0.0 szedep=$root/sze/usr-1.1.4 if echo $DPDK_TARGET | grep -q '^x86_64' ; then export DPDK_DEP_ARCHIVE=y export DPDK_DEP_ZLIB=y export DPDK_DEP_PCAP=y export DPDK_DEP_SSL=y export DPDK_DEP_MOFED=y export DPDK_DEP_SZE=y export DPDK_DEP_CFLAGS="-I$mlxdep/include -I$szedep/include" export DPDK_DEP_LDFLAGS="-L$mlxdep/lib -L$szedep/lib64 -rpath=$szedep/lib64" export AESNI_MULTI_BUFFER_LIB_PATH=$root/aesni/ipsec-043 export LIBSSO_SNOW3G_PATH=$root/libsso/libsso-snow3g-0.3.1 export LIBSSO_KASUMI_PATH=$root/libsso/libsso-kasumi-0.3.1 fi > I used 'x86_64-native-linuxapp-gcc+default+debug+shared' for all patches. It is a good idea to test also with clang (x86_64-native-linuxapp-clang) and another arch (e.g. arm64-thunderx-linuxapp-gcc).